Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1657843003: Output TimelineEventBlocks in sorted order (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Output TimelineEventBlocks in sorted order - Before outputting to JSON sort TimelineEventBlocks by earliest event time. - Output using sorted block order. - Works around a bug in mojo (https://github.com/domokit/mojo/issues/649) R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/33aaf940e522cc1ad7bdceaabcc32a48da86b2cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M runtime/vm/timeline.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/timeline.cc View 4 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 10 months ago (2016-02-01 21:04:00 UTC) #4
zra
lgtm
4 years, 10 months ago (2016-02-01 21:09:03 UTC) #5
Cutch
4 years, 10 months ago (2016-02-01 21:12:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
33aaf940e522cc1ad7bdceaabcc32a48da86b2cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698