Issue 1657823003: Add limited support for Mac to CMake generator.

Issue 1657823003: Add limited support for Mac to CMake generator. (Closed)

Created:
4 years, 10 months ago by bungeman-chromium

Modified:
4 years, 10 months ago

Reviewers:
herb_g, bsalomon_chromium

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

Add limited support for Mac to CMake generator. This adds enough support for Mac to the CMake generator to build simple targets. This allows for use with CLion on the Mac. R=herb@google.com Committed: https://chromium.googlesource.com/external/gyp/+/87ac4d0e63fc7dd8152a350327fea8dcf031bf56

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -12 lines)			Patch
	M	pylib/gyp/generator/cmake.py	View	1	11 chunks	+39 lines, -12 lines	0 comments	Download

Total messages: 7 (3 generated)

bungeman-chromium

A possible alternative to https://crrev.com/1162713005

4 years, 10 months ago (2016-02-01 22:07:43 UTC) #2

herb_g

lgtm I patched this into a clean branch, and Clion builds DM. I vote this ...

4 years, 10 months ago (2016-02-03 17:02:24 UTC) #5

bungeman-chromium

4 years, 10 months ago (2016-02-03 18:45:00 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
87ac4d0e63fc7dd8152a350327fea8dcf031bf56 (presubmit successful).