Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: src/snapshot-common.cc

Issue 16578008: Improved function entry hook coverage (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@post_fix
Patch Set: WIP: Fix X64 implementation. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/isolate.cc ('K') | « src/isolate.cc ('k') | src/v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot-common.cc
diff --git a/src/snapshot-common.cc b/src/snapshot-common.cc
old mode 100644
new mode 100755
index a8806f053fe13b2f796c9009eb05c48843217394..8dab3671cef9f16451e6ea26a86f113b43d1e3b2
--- a/src/snapshot-common.cc
+++ b/src/snapshot-common.cc
@@ -82,6 +82,12 @@ void Snapshot::ReserveSpaceForLinkedInSnapshot(Deserializer* deserializer) {
bool Snapshot::Initialize(const char* snapshot_file) {
danno 2013/06/13 15:33:44 If you need the isolate, you should pass it in as
Sigurður Ásgeirsson 2013/06/19 20:51:51 Moved this to the sole non-test user of this funct
+ // If the isolate has a function entry hook, it needs to re-build all its
+ // code stubs with entry hooks embedded.
+ Isolate* isolate = Isolate::UncheckedCurrent();
+ if (isolate && isolate->HasFunctionEntryHook())
danno 2013/06/13 15:33:44 nit: isolate != NULL
Sigurður Ásgeirsson 2013/06/19 20:51:51 Done.
+ return false;
+
if (snapshot_file) {
int len;
byte* str = ReadBytes(snapshot_file, &len);
« src/isolate.cc ('K') | « src/isolate.cc ('k') | src/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698