Improved function entry hook coverage

src/snapshot-common.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 63 matching lines @@
 void Snapshot::ReserveSpaceForLinkedInSnapshot(Deserializer* deserializer) {
   deserializer->set_reservation(NEW_SPACE, new_space_used_);
   deserializer->set_reservation(OLD_POINTER_SPACE, pointer_space_used_);
   deserializer->set_reservation(OLD_DATA_SPACE, data_space_used_);
   deserializer->set_reservation(CODE_SPACE, code_space_used_);
   deserializer->set_reservation(MAP_SPACE, map_space_used_);
   deserializer->set_reservation(CELL_SPACE, cell_space_used_);
 }
 
 
 bool Snapshot::Initialize(const char* snapshot_file) {

[danno, 2013/06/13 15:33:44]

If you need the isolate, you should pass it in as a parameter.

[Sigurður Ásgeirsson, 2013/06/19 20:51:51]

Moved this to the sole non-test user of this function, as I'm not sure how to
otherwise untangle this.

+  // If the isolate has a function entry hook, it needs to re-build all its
+  // code stubs with entry hooks embedded.
+  Isolate* isolate = Isolate::UncheckedCurrent();
+  if (isolate && isolate->HasFunctionEntryHook())

[danno, 2013/06/13 15:33:44]

nit: isolate != NULL

[Sigurður Ásgeirsson, 2013/06/19 20:51:51]

Done.

+    return false;
+
   if (snapshot_file) {
     int len;
     byte* str = ReadBytes(snapshot_file, &len);
     if (!str) return false;
     bool success;
     {
       SnapshotByteSource source(str, len);
       Deserializer deserializer(&source);
       ReserveSpaceForSnapshot(&deserializer, snapshot_file);
       success = V8::Initialize(&deserializer);
@@ skipping 28 matching lines @@
   deserializer.set_reservation(OLD_DATA_SPACE, context_data_space_used_);
   deserializer.set_reservation(CODE_SPACE, context_code_space_used_);
   deserializer.set_reservation(MAP_SPACE, context_map_space_used_);
   deserializer.set_reservation(CELL_SPACE, context_cell_space_used_);
   deserializer.DeserializePartial(&root);
   CHECK(root->IsContext());
   return Handle<Context>(Context::cast(root));
 }
 
 } }  // namespace v8::internal