Issue 16578: Add debug menu to Linux test_shell:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16578: Add debug menu to Linux test_shell: (Closed)

Created:
11 years, 11 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tony, agl, Evan Martin, Dean McNamee

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add debug menu to Linux test_shell: - Dump body text... - Dump render tree... - Show web inspector... BUG=5122, 6050

Patch Set 2 : fix indentation #

Patch Set 3 : curlies & 80 chars #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -117 lines)			Patch
M	webkit/tools/test_shell/test_shell.cc	View	1 2	2 chunks	+22 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	1 2	4 chunks	+73 lines, -53 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

agl

Looks good except for the whitespace in the noted function. http://codereview.chromium.org/16578/diff/1/3 File webkit/tools/test_shell/test_shell_gtk.cc (right): http://codereview.chromium.org/16578/diff/1/3#newcode577 ...

11 years, 11 months ago (2009-01-07 18:29:37 UTC) #2

Evan Martin

awesome. http://codereview.chromium.org/16578/diff/1/2 File webkit/tools/test_shell/test_shell.cc (right): http://codereview.chromium.org/16578/diff/1/2#newcode436 Line 436: { I see this wasn't your code ...

11 years, 11 months ago (2009-01-07 18:37:33 UTC) #3

LGTM