src/parsing/parser.h - Issue 1657783002: Gracefully handle syntax errors in Parser::PatternRewriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.h

Issue 1657783002: Gracefully handle syntax errors in Parser::PatternRewriter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Unit test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/parser.h

diff --git a/src/parsing/parser.h b/src/parsing/parser.h

index c37953f04ad3c24480d8f57303e2ade4340ae02c..dbce26b09ec9746a63f1e405f00603a731deadb9 100644

--- a/src/parsing/parser.h

+++ b/src/parsing/parser.h

@@ -832,6 +832,8 @@ class Parser : public ParserBase<ParserTraits> {

void set_context(PatternContext context) { context_ = context; }

void RecurseIntoSubpattern(AstNode* pattern, Expression* value) {

+ if (!*ok_) return;

Expression* old_value = current_value_;

current_value_ = value;

recursion_level_++;

« no previous file with comments | « no previous file | src/parsing/pattern-rewriter.cc » ('j') | no next file with comments »