Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Unified Diff: gm/imagefilterscropped.cpp

Issue 1657773002: Fix zero-sized blur with crop rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Do all early-outs before allocating dst Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/effects/SkBlurImageFilter.cpp » ('j') | src/effects/SkBlurImageFilter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/imagefilterscropped.cpp
diff --git a/gm/imagefilterscropped.cpp b/gm/imagefilterscropped.cpp
index 4c6ef623561a450834afb2600f1b9f37d50f09b0..569ce3c8c8f4fc850f6ea14364b3c1d55a11113a 100644
--- a/gm/imagefilterscropped.cpp
+++ b/gm/imagefilterscropped.cpp
@@ -76,7 +76,7 @@ protected:
return SkString("imagefilterscropped");
}
robertphillips 2016/02/01 17:41:35 rm virtual here and on 'onShortName' ?
Stephen White 2016/02/01 18:20:03 Done.
- virtual SkISize onISize() override { return SkISize::Make(400, 880); }
+ virtual SkISize onISize() override { return SkISize::Make(400, 960); }
void make_checkerboard() {
fCheckerboard.allocN32Pixels(80, 80);
@@ -131,6 +131,7 @@ protected:
SkImageFilter* filters[] = {
nullptr,
SkColorFilterImageFilter::Create(cf.get(), nullptr, &cropRect),
+ SkBlurImageFilter::Create(0.0f, 0.0f, nullptr, &cropRect),
SkBlurImageFilter::Create(1.0f, 1.0f, nullptr, &cropRect),
SkBlurImageFilter::Create(8.0f, 0.0f, nullptr, &cropRect),
SkBlurImageFilter::Create(0.0f, 8.0f, nullptr, &cropRect),
« no previous file with comments | « no previous file | src/effects/SkBlurImageFilter.cpp » ('j') | src/effects/SkBlurImageFilter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698