Fix zero-sized blur with crop rect.

Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657773002

Committed: https://skia.googlesource.com/skia/+/6404981b0c3984ba91b3bda35e60c6c8a8a773c2

[Stephen White, 2016-02-01 16:23:48]

Description was changed from

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
==========

to

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-01 16:24:05]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 16:24:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657773002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657773002/1

[commit-bot: I haz the power, 2016-02-01 16:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 16:38:26]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[Stephen White, 2016-02-01 16:45:29]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-01 16:45:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657773002/20001

[Stephen White, 2016-02-01 16:49:45]

Description was changed from

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-02-01 16:49:45]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2016-02-01 16:49:55]

Rob: PTAL. Thanks!

[commit-bot: I haz the power, 2016-02-01 17:00:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 17:00:01]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-01 17:41:36]

lgtm + nits

https://codereview.chromium.org/1657773002/diff/20001/gm/imagefilterscropped.cpp
File gm/imagefilterscropped.cpp (right):

https://codereview.chromium.org/1657773002/diff/20001/gm/imagefilterscropped....
gm/imagefilterscropped.cpp:78: 
rm virtual here and on 'onShortName' ?

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
File src/effects/SkBlurImageFilter.cpp (right):

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
src/effects/SkBlurImageFilter.cpp:27: 
map_sigma ?

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
src/effects/SkBlurImageFilter.cpp:214: SkVector sigma = mapSigma(fSigma,
ctx.ctm());
Do we need/want an epsilon-based comparison here ?

[Stephen White, 2016-02-01 18:20:03]

Thanks for your review.

https://codereview.chromium.org/1657773002/diff/20001/gm/imagefilterscropped.cpp
File gm/imagefilterscropped.cpp (right):

https://codereview.chromium.org/1657773002/diff/20001/gm/imagefilterscropped....
gm/imagefilterscropped.cpp:78: 
On 2016/02/01 17:41:35, robertphillips wrote:
> rm virtual here and on 'onShortName' ?

Done.

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
File src/effects/SkBlurImageFilter.cpp (right):

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
src/effects/SkBlurImageFilter.cpp:27: 
On 2016/02/01 17:41:35, robertphillips wrote:
> map_sigma ?

Done.

https://codereview.chromium.org/1657773002/diff/20001/src/effects/SkBlurImage...
src/effects/SkBlurImageFilter.cpp:214: SkVector sigma = mapSigma(fSigma,
ctx.ctm());
On 2016/02/01 17:41:35, robertphillips wrote:
> Do we need/want an epsilon-based comparison here ?

Since GaussianBlur() does exact comparisons as well (and only
does the wrong thing when they're exactly zero), it should be
safe to do here as well.

[Stephen White, 2016-02-01 18:20:35]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-02-01 18:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1657773002/#ps40001
(title: "Fixes per review comments")

[commit-bot: I haz the power, 2016-02-01 18:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657773002/40001

[commit-bot: I haz the power, 2016-02-01 18:32:44]

Description was changed from

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix zero-sized blur with crop rect.

Neither the GPU nor CPU paths were correctly handling the crop rect
in this case.

NOTE: this change adds a new test case to the imageblurcropped GM, so
it will have to be rebaselined.

BUG=skia:4876
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6404981b0c3984ba91b3bda35e60c6c8a8a773c2
==========

[commit-bot: I haz the power, 2016-02-01 18:32:44]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6404981b0c3984ba91b3bda35e60c6c8a8a773c2