Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165773004: CC: Add test for implicit limit overflow. (Closed)

Created:
6 years, 10 months ago by epenner
Modified:
6 years, 10 months ago
Reviewers:
danakj, epennerAtGoogle
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CC_fix_mem_overflow
Visibility:
Public.

Description

We just fixed an overflow but test was removed for easier merge. This just adds the test: Here is the fix: https://codereview.chromium.org/175543002/ BUG=345426 TBR=danakj@chromium.org Carrying forward LGTM from prior patch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253051

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
cc/trees/layer_tree_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 10 months ago (2014-02-24 00:44:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/165773004/30001
6 years, 10 months ago (2014-02-24 00:44:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 01:40:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=153356
6 years, 10 months ago (2014-02-24 01:40:20 UTC) #4
epennerAtGoogle
The CQ bit was checked by epenner@google.com
6 years, 10 months ago (2014-02-24 18:20:21 UTC) #5
epenner
The CQ bit was unchecked by epenner@chromium.org
6 years, 10 months ago (2014-02-24 18:20:33 UTC) #6
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 10 months ago (2014-02-24 18:20:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/165773004/30001
6 years, 10 months ago (2014-02-24 18:21:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/165773004/30001
6 years, 10 months ago (2014-02-24 20:24:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/165773004/30001
6 years, 10 months ago (2014-02-24 21:08:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/165773004/30001
6 years, 10 months ago (2014-02-25 01:20:59 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 02:02:34 UTC) #12
Message was sent while issue was closed. 
Change committed as 253051

Powered by Google App Engine
This is Rietveld 408576698