Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Issue 1657693002: Modify app.yaml in the built AppRTC rather in src. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify app.yaml in the built AppRTC rather in src. When I switched to prebuilt AppRTC, I forgot we need to modify the built app.yaml rather the one in src. This used to work because we ran grunt build after the copy (which copied the file I modified), but after switching to pre-built we're effectively running grunt build _before_ the copy. This caused copy_apprtc.py to write to a config file that wasn't read by the server on startup. We could also delete the code and just flip the flag during apprtc.zip packaging, but that seems tedious and error-prone. BUG=581283 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/a511540b0d6407cf02ce01ad06746e43f3657946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M copy_apprtc.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
phoglund_chromium
4 years, 10 months ago (2016-02-01 15:18:30 UTC) #2
kjellander_chromium
lgtm
4 years, 10 months ago (2016-02-01 15:56:31 UTC) #3
phoglund_chromium
4 years, 10 months ago (2016-02-01 16:10:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a511540b0d6407cf02ce01ad06746e43f3657946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698