Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1657663003: Merge to XFA: Remove CGW_ArrayTemplate and its O(n^2 log n) sort. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove CGW_ArrayTemplate and its O(n^2 log n) sort. Original Review URL: https://codereview.chromium.org/1652613002 . (cherry picked from commit 0841b0f37678ba4962247f5636e9390718fc027e) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b9cc7a0d0ece261db2cd2a1486b05e3338bca322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -235 lines) Patch
M fpdfsdk/include/fsdk_baseform.h View 3 chunks +13 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +1 line, -73 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 3 chunks +73 lines, -134 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 3 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
tbr
4 years, 10 months ago (2016-02-01 21:40:45 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as b9cc7a0d0ece261db2cd2a1486b05e3338bca322 (presubmit successful).
4 years, 10 months ago (2016-02-01 21:42:34 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-01 21:46:14 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698