Implement "expand/collapse artwork" button in audio player.

Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually

Committed: https://crrev.com/6f17c22c98a7111bd519b221fb6cdd61c54d0d90
Cr-Commit-Position: refs/heads/master@{#372917}

[ryoh, 2016-02-01 09:14:34]

Description was changed from

==========
t gu# Enter a description of the change.
add expanded-artwork to audo player.

Implement "expand/collapse artwork" button in audio player.
"artwork-unavailable" illust is not available now, we use a temporally image now
instead.

BUG=578022
TEST=manually
==========

to

==========
Implement "expand/collapse artwork" button in audio player.

Implement "expand/collapse artwork" button in audio player.
"artwork-unavailable" illust is not available now, we use a temporally image now
instead.

BUG=578022
TEST=manually
==========

[ryoh, 2016-02-01 09:14:45]

Description was changed from

==========
Implement "expand/collapse artwork" button in audio player.

Implement "expand/collapse artwork" button in audio player.
"artwork-unavailable" illust is not available now, we use a temporally image now
instead.

BUG=578022
TEST=manually
==========

to

==========
Implement "expand/collapse artwork" button in audio player.

"artwork-unavailable" illust is not available now, we use a temporally image now
instead.

BUG=578022
TEST=manually
==========

[ryoh, 2016-02-01 09:19:13]

ryoh@chromium.org changed reviewers:
+ fukino@chromium.org

[ryoh, 2016-02-01 09:19:14]

Hi, I implemented "expand-artwork" panel.
Could you take a look?

an alternative image for songs with no-artwork is now a temporal image,
but coding work has done.

[ryoh, 2016-02-02 05:41:07]

Description was changed from

==========
Implement "expand/collapse artwork" button in audio player.

"artwork-unavailable" illust is not available now, we use a temporally image now
instead.

BUG=578022
TEST=manually
==========

to

==========
Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually
==========

[fukino, 2016-02-02 06:24:20]

Thanks!

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/elements/track_info_panel.css (left):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:10: display: flex;
I think this shouldn't be removed. If it is block, flex-direction and
justify-content can be applied for flex containers.

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/elements/track_info_panel.css (right):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:62: width: 320px;
The width of audio player is not necessarily 320px. You can change the width.
Could you take care of a case when the width is expanded?

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:75:
url(../assets/100/player_no_artwork.png) 1x,
As player_no_artwork.png is big, could you reduce the size using
https://code.google.com/p/chromium/codesearch#chromium/src/tools/resources/op...
?

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/js/audio_player.js:501:
AudioPlayer.prototype.syncHeightForPlaylist_ = function() {
Somehow I see extra 4 or 5 pixel margin above the playlist.

[ryoh, 2016-02-02 08:15:49]

Could you take another look?
To remove the extra space,
I updated the style sheet of main window.

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/elements/track_info_panel.css (left):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:10: display: flex;
On 2016/02/02 06:24:20, fukino wrote:
> I think this shouldn't be removed. If it is block, flex-direction and
> justify-content can be applied for flex containers.

We no longer use flex. Just a block.
I removed flex-direction and justfy-content. Thanks.

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/elements/track_info_panel.css (right):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:62: width: 320px;
On 2016/02/02 06:24:20, fukino wrote:
> The width of audio player is not necessarily 320px. You can change the width.
> Could you take care of a case when the width is expanded?

Done.

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/elements/track_info_panel.css:75:
url(../assets/100/player_no_artwork.png) 1x,
On 2016/02/02 06:24:20, fukino wrote:
> As player_no_artwork.png is big, could you reduce the size using
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/resources/op...
> ?

Done.

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
File ui/file_manager/audio_player/js/audio_player.js (right):

https://codereview.chromium.org/1657623002/diff/120001/ui/file_manager/audio_...
ui/file_manager/audio_player/js/audio_player.js:501:
AudioPlayer.prototype.syncHeightForPlaylist_ = function() {
On 2016/02/02 06:24:20, fukino wrote:
> Somehow I see extra 4 or 5 pixel margin above the playlist.

Done.

[fukino, 2016-02-02 08:33:33]

Thanks! LGTM with a nit.

https://codereview.chromium.org/1657623002/diff/180001/ui/file_manager/audio_...
File ui/file_manager/audio_player/css/audio_player.css (right):

https://codereview.chromium.org/1657623002/diff/180001/ui/file_manager/audio_...
ui/file_manager/audio_player/css/audio_player.css:31: box-sizing: border-box;
nit: sort properties.

[ryoh, 2016-02-02 08:56:05]

The CQ bit was checked by ryoh@chromium.org

[ryoh, 2016-02-02 08:56:05]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1657623002/#ps200001
(title: "sorting css prop.")

[commit-bot: I haz the power, 2016-02-02 08:56:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657623002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657623002/200001

[commit-bot: I haz the power, 2016-02-02 09:30:36]

Description was changed from

==========
Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually
==========

to

==========
Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually
==========

[commit-bot: I haz the power, 2016-02-02 09:30:37]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-02-02 09:32:30]

Description was changed from

==========
Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually
==========

to

==========
Implement "expand/collapse artwork" button in audio player.

BUG=578022
TEST=manually

Committed: https://crrev.com/6f17c22c98a7111bd519b221fb6cdd61c54d0d90
Cr-Commit-Position: refs/heads/master@{#372917}
==========

[commit-bot: I haz the power, 2016-02-02 09:32:31]

Patchset 11 (id:??) landed as
https://crrev.com/6f17c22c98a7111bd519b221fb6cdd61c54d0d90
Cr-Commit-Position: refs/heads/master@{#372917}