Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 1657613004: dart2js cps: More type rules in type propagation. (Closed)

Created:
4 years, 10 months ago by asgerf
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: More type rules in type propagation. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/703a7fcc6dfd4ebc056a5d1118dccbc8ece110f8

Patch Set 1 #

Patch Set 2 : Fix handling of tear-offs and update test expectation #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -31 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 11 chunks +49 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/operators_4.js View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
asgerf
4 years, 10 months ago (2016-02-02 17:01:31 UTC) #3
asgerf
4 years, 10 months ago (2016-02-05 09:13:25 UTC) #5
Kevin Millikin (Google)
lgtm
4 years, 10 months ago (2016-02-05 10:12:05 UTC) #6
asgerf
4 years, 10 months ago (2016-02-05 11:10:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
703a7fcc6dfd4ebc056a5d1118dccbc8ece110f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698