Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: lib/src/runner.dart

Issue 1657613003: Eagerly close browser tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/runner/browser/server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner.dart
diff --git a/lib/src/runner.dart b/lib/src/runner.dart
index 95caaf6810f46f018d92842668b62389c26b81d0..517e3a09f8c5b2597993b819f249fd93b38e6640 100644
--- a/lib/src/runner.dart
+++ b/lib/src/runner.dart
@@ -166,7 +166,14 @@ class Runner {
// Make sure we close the engine *before* the loader. Otherwise,
// LoadSuites provided by the loader may get into bad states.
- await _engine.close();
+ //
+ // We close the loader's browsers while we're closing the engine because
+ // browser tests don't store any state we care about and we want them to
+ // shut down without waiting for their tear-downs.
+ await Future.wait([
+ _loader.closeBrowsers(),
+ _engine.close()
+ ]);
if (timer != null) timer.cancel();
await _loader.close();
});
« no previous file with comments | « no previous file | lib/src/runner/browser/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698