Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.h

Issue 1657593007: Implement chrome.input.ime.setComposition/commitText API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Checkout InputImeEventRouter. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.h
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.h b/chrome/browser/chromeos/input_method/input_method_engine.h
index 9420a48cafe676f5e244e91a1080495623a7df98..d9b44ca58894050e3fb54ee27c5da4a0015caf0d 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.h
+++ b/chrome/browser/chromeos/input_method/input_method_engine.h
@@ -151,6 +151,12 @@ class InputMethodEngine : public ::input_method::InputMethodEngineBase {
// Enables overriding input view page to Virtual Keyboard window.
void EnableInputView();
+ // input_method::InputMethodEngineBase:
+ void UpdateComposition(const ui::CompositionText& composition_text,
+ uint32_t cursor_pos,
+ bool is_visible) override;
+ void CommitTextToInputContext(int context_id, const char* text) override;
Devlin 2016/02/04 00:09:17 Is there a reason this has to be a const char* ins
Azure Wei 2016/02/04 03:21:19 Yeah, it's more convenient to use const std::strin
+
// The current candidate window.
scoped_ptr<ui::CandidateWindow> candidate_window_;

Powered by Google App Engine
This is Rietveld 408576698