Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: ui/base/ime/input_method_chromeos.h

Issue 1657593007: Implement chrome.input.ime.setComposition/commitText API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_chromeos.h
diff --git a/ui/base/ime/input_method_chromeos.h b/ui/base/ime/input_method_chromeos.h
index 83da4e4886ae496d43cae3ac0e8abf18854a552e..f63485a21da57a5ccb9c105dfad4b9d1bd3de8d7 100644
--- a/ui/base/ime/input_method_chromeos.h
+++ b/ui/base/ime/input_method_chromeos.h
@@ -22,9 +22,7 @@
namespace ui {
// A ui::InputMethod implementation based on IBus.
-class UI_BASE_IME_EXPORT InputMethodChromeOS
- : public InputMethodBase,
- public ui::IMEInputContextHandlerInterface {
+class UI_BASE_IME_EXPORT InputMethodChromeOS : public InputMethodBase {
public:
explicit InputMethodChromeOS(internal::InputMethodDelegate* delegate);
~InputMethodChromeOS() override;
@@ -89,10 +87,6 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
// Checks if there is pending input method result.
bool HasInputMethodResult() const;
- // Sends a fake key event for IME composing without physical key events.
- // Returns true if the faked key event is stopped propagation.
- bool SendFakeProcessKeyEvent(bool pressed) const;
-
// Passes keyevent and executes character composition if necessary. Returns
// true if character composer comsumes key event.
bool ExecuteCharacterComposer(const ui::KeyEvent& event);
@@ -139,10 +133,6 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
// including dead key etc.
CharacterComposer character_composer_;
- // Indicates whether currently is handling a physical key event.
- // This is used in CommitText/UpdateCompositionText/etc.
- bool handling_key_event_;
-
// Used for making callbacks.
base::WeakPtrFactory<InputMethodChromeOS> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698