chrome/browser/ui/input_method/input_method_engine.h - Issue 1657593007: Implement chrome.input.ime.setComposition/commitText API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/input_method/input_method_engine.h

Issue 1657593007: Implement chrome.input.ime.setComposition/commitText API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use Xxx::Results::Create(). Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc ('k') | chrome/browser/ui/input_method/input_method_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/input_method/input_method_engine.h

diff --git a/chrome/browser/ui/input_method/input_method_engine.h b/chrome/browser/ui/input_method/input_method_engine.h

index 273213d3939017f47ee121ccb20591a137dab748..5ae98bdc395e84d1a03c8bf2f0e73f807e1b25b6 100644

--- a/chrome/browser/ui/input_method/input_method_engine.h

+++ b/chrome/browser/ui/input_method/input_method_engine.h

@@ -24,6 +24,13 @@ class InputMethodEngine : public InputMethodEngineBase {

std::string GetExtensionId() const override;

private:

+ // input_method::InputMethodEngineBase:

+ void UpdateComposition(const ui::CompositionText& composition_text,

+ uint32_t cursor_pos,

+ bool is_visible) override;

+ void CommitTextToInputContext(int context_id,

+ const std::string& text) override;

DISALLOW_COPY_AND_ASSIGN(InputMethodEngine);

};