Implement chrome.input.ime.setComposition/commitText API.

chrome/browser/ui/input_method/input_method_engine_base.cc

Index: chrome/browser/ui/input_method/input_method_engine_base.cc
diff --git a/chrome/browser/ui/input_method/input_method_engine_base.cc b/chrome/browser/ui/input_method/input_method_engine_base.cc
index 6cd3a6412a8490e8e9f83855ee09d7d0cd56556d..59e61159db9c8a094609c467214f858d0fd61db0 100644
--- a/chrome/browser/ui/input_method/input_method_engine_base.cc
+++ b/chrome/browser/ui/input_method/input_method_engine_base.cc
@@ -47,30 +47,6 @@ namespace {
 const char kErrorNotActive[] = "IME is not active";
 const char kErrorWrongContext[] = "Context is not active";
 
-// Notifies InputContextHandler that the composition is changed.
-void UpdateComposition(const ui::CompositionText& composition_text,
-                       uint32_t cursor_pos,
-                       bool is_visible) {
-  ui::IMEInputContextHandlerInterface* input_context =
-      ui::IMEBridge::Get()->GetInputContextHandler();
-  if (input_context)
-    input_context->UpdateCompositionText(composition_text, cursor_pos,
-                                         is_visible);
-}
-
-// Returns the length of characters of a UTF-8 string with unknown string
-// length. Cannot apply faster algorithm to count characters in an utf-8
-// string without knowing the string length,  so just does a full scan.
-size_t GetUtf8StringLength(const char* s) {
-  size_t ret = 0;
-  while (*s) {
-    if ((*s & 0xC0) != 0x80)
-      ret++;
-    ++s;
-  }
-  return ret;
-}
-
 #if defined(OS_CHROMEOS)
 std::string GetKeyFromEvent(const ui::KeyEvent& event) {
   const std::string code = event.GetCodeString();
@@ -180,7 +156,9 @@ InputMethodEngineBase::InputMethodEngineBase()
       composition_text_(new ui::CompositionText()),
       composition_cursor_(0),
       sent_key_event_(NULL),
-      profile_(NULL) {}
+      profile_(NULL),

[Shu Chen, 2016/02/04 08:00:46]

s/NULL/nullptr/g

[Azure Wei, 2016/02/04 11:57:21]

Done.

+      text_(""),
+      handling_key_event_(false) {}
 
 InputMethodEngineBase::~InputMethodEngineBase() {}
 
@@ -284,14 +262,7 @@ bool InputMethodEngineBase::CommitText(int context_id,
     return false;
   }
 
-  ui::IMEBridge::Get()->GetInputContextHandler()->CommitText(text);
-
-  // Records histograms for committed characters.
-  if (!composition_text_->text.empty()) {
-    size_t len = GetUtf8StringLength(text);
-    UMA_HISTOGRAM_CUSTOM_COUNTS("InputMethod.CommitLength", len, 1, 25, 25);
-    composition_text_.reset(new ui::CompositionText());
-  }
+  CommitTextToInputContext(context_id, std::string(text));
   return true;
 }
 
@@ -379,6 +350,10 @@ bool InputMethodEngineBase::IsInterestedInKeyEvent() const {
 
 void InputMethodEngineBase::ProcessKeyEvent(const ui::KeyEvent& key_event,
                                             KeyEventDoneCallback& callback) {
+  // Make true that we don't handle IME API calling of setComposition and
+  // commitText while the extension is handling key event.
+  handling_key_event_ = true;
+
   KeyboardEvent ext_event;
   GetExtensionKeyboardEventFromKeyEvent(key_event, &ext_event);
 
@@ -401,4 +376,23 @@ void InputMethodEngineBase::SetSurroundingText(const std::string& text,
       static_cast<int>(anchor_pos), static_cast<int>(offset_pos));
 }
 
+void InputMethodEngineBase::KeyEventHandled() {
+  handling_key_event_ = false;
+  // When finish handling key event, take care of the unprocessed setComposition
+  // and commitText calls.
+  ui::IMEInputContextHandlerInterface* input_context =
+      ui::IMEBridge::Get()->GetInputContextHandler();
+  if (!composition_.text.empty()) {
+    if (input_context)

[Shu Chen, 2016/02/04 08:00:46]

bracket.

[Azure Wei, 2016/02/04 11:57:21]

Done.

+      input_context->UpdateCompositionText(
+          composition_, composition_.selection.start(), true);
+    composition_.Clear();
+  }
+  if (!text_.empty()) {
+    if (input_context)
+      input_context->CommitText(text_);
+    text_ = "";
+  }
+}
+
 }  // namespace input_method