Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1657583002: Disallow scripting earlier in LocalFrame::detach(). (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow scripting earlier in LocalFrame::detach(). The Chrome extension implementation no longer needs to run script in WebFrameClient::willReleaseScriptContext(), so forbid scripting earlier in detach to make it harder to break invariants. BUG=534923, 555773 Committed: https://crrev.com/718b48fe05a4405c2edf2748e3819c5a2b8ccd3e Cr-Commit-Position: refs/heads/master@{#372611}

Patch Set 1 #

Patch Set 2 : Add comments and move script forbidden scope. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dcheng
(Assuming this passes all the remaining trybot runs, but so far, it looks good)
4 years, 10 months ago (2016-02-01 05:05:33 UTC) #4
haraken
LGTM
4 years, 10 months ago (2016-02-01 05:14:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657583002/20001
4 years, 10 months ago (2016-02-01 06:03:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 06:08:31 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 06:09:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/718b48fe05a4405c2edf2748e3819c5a2b8ccd3e
Cr-Commit-Position: refs/heads/master@{#372611}

Powered by Google App Engine
This is Rietveld 408576698