Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
index 8994abc89d7d3e8b5f940a23debdd022b3592f41..a21b8940f7853c8b074b58feac1ae78c4af04d40 100644
--- a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
@@ -44,6 +44,7 @@ void HTMLImageFallbackHelper::createAltTextShadowTree(Element& element)
container->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInlineBlock);
container->setInlineStyleProperty(CSSPropertyBoxSizing, CSSValueBorderBox);
container->setInlineStyleProperty(CSSPropertyPadding, 1, CSSPrimitiveValue::UnitType::Pixels);
+ container->setInlineStyleProperty(CSSPropertyBorderRadius, AtomicString("inherit", AtomicString::ConstructFromLiteral));
pdr. 2016/03/07 21:15:50 How does the code in InlineFlowBox::nodeAtPoint re
Miyoung Shin(c) 2016/03/09 12:28:07 Yes, we need both of them, because container(DIV)
pdr. 2016/03/21 05:26:10 Does a test depend on this? both border-hittest.ht
Miyoung Shin(c) 2016/03/29 22:49:40 The new test(border-hittest-with-image-fallback.ht
RefPtrWillBeRawPtr<HTMLImageElement> brokenImage = HTMLImageElement::create(element.document());
container->appendChild(brokenImage);

Powered by Google App Engine
This is Rietveld 408576698