Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/HTMLImageFallbackHelper.h" 5 #include "core/html/HTMLImageFallbackHelper.h"
6 6
7 #include "core/HTMLNames.h" 7 #include "core/HTMLNames.h"
8 #include "core/InputTypeNames.h" 8 #include "core/InputTypeNames.h"
9 #include "core/dom/ElementRareData.h" 9 #include "core/dom/ElementRareData.h"
10 #include "core/dom/Text.h" 10 #include "core/dom/Text.h"
(...skipping 26 matching lines...) Expand all
37 RefPtrWillBeRawPtr<HTMLDivElement> container = HTMLDivElement::create(elemen t.document()); 37 RefPtrWillBeRawPtr<HTMLDivElement> container = HTMLDivElement::create(elemen t.document());
38 root.appendChild(container); 38 root.appendChild(container);
39 container->setAttribute(idAttr, AtomicString("alttext-container", AtomicStri ng::ConstructFromLiteral)); 39 container->setAttribute(idAttr, AtomicString("alttext-container", AtomicStri ng::ConstructFromLiteral));
40 container->setInlineStyleProperty(CSSPropertyOverflow, CSSValueHidden); 40 container->setInlineStyleProperty(CSSPropertyOverflow, CSSValueHidden);
41 container->setInlineStyleProperty(CSSPropertyBorderWidth, 1, CSSPrimitiveVal ue::UnitType::Pixels); 41 container->setInlineStyleProperty(CSSPropertyBorderWidth, 1, CSSPrimitiveVal ue::UnitType::Pixels);
42 container->setInlineStyleProperty(CSSPropertyBorderStyle, CSSValueSolid); 42 container->setInlineStyleProperty(CSSPropertyBorderStyle, CSSValueSolid);
43 container->setInlineStyleProperty(CSSPropertyBorderColor, CSSValueSilver); 43 container->setInlineStyleProperty(CSSPropertyBorderColor, CSSValueSilver);
44 container->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInlineBlock); 44 container->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInlineBlock);
45 container->setInlineStyleProperty(CSSPropertyBoxSizing, CSSValueBorderBox); 45 container->setInlineStyleProperty(CSSPropertyBoxSizing, CSSValueBorderBox);
46 container->setInlineStyleProperty(CSSPropertyPadding, 1, CSSPrimitiveValue:: UnitType::Pixels); 46 container->setInlineStyleProperty(CSSPropertyPadding, 1, CSSPrimitiveValue:: UnitType::Pixels);
47 container->setInlineStyleProperty(CSSPropertyBorderRadius, AtomicString("inh erit", AtomicString::ConstructFromLiteral));
pdr. 2016/03/31 04:20:11 I still don't see why this is needed. Which test f
Miyoung Shin(c) 2016/04/03 14:39:25 border-hittest-with-image-fallback.html is failed
47 48
48 RefPtrWillBeRawPtr<HTMLImageElement> brokenImage = HTMLImageElement::create( element.document()); 49 RefPtrWillBeRawPtr<HTMLImageElement> brokenImage = HTMLImageElement::create( element.document());
49 container->appendChild(brokenImage); 50 container->appendChild(brokenImage);
50 brokenImage->setIsFallbackImage(); 51 brokenImage->setIsFallbackImage();
51 brokenImage->setAttribute(idAttr, AtomicString("alttext-image", AtomicString ::ConstructFromLiteral)); 52 brokenImage->setAttribute(idAttr, AtomicString("alttext-image", AtomicString ::ConstructFromLiteral));
52 brokenImage->setAttribute(widthAttr, AtomicString("16", AtomicString::Constr uctFromLiteral)); 53 brokenImage->setAttribute(widthAttr, AtomicString("16", AtomicString::Constr uctFromLiteral));
53 brokenImage->setAttribute(heightAttr, AtomicString("16", AtomicString::Const ructFromLiteral)); 54 brokenImage->setAttribute(heightAttr, AtomicString("16", AtomicString::Const ructFromLiteral));
54 brokenImage->setAttribute(alignAttr, AtomicString("left", AtomicString::Cons tructFromLiteral)); 55 brokenImage->setAttribute(alignAttr, AtomicString("left", AtomicString::Cons tructFromLiteral));
55 brokenImage->setInlineStyleProperty(CSSPropertyMargin, 0, CSSPrimitiveValue: :UnitType::Pixels); 56 brokenImage->setInlineStyleProperty(CSSPropertyMargin, 0, CSSPrimitiveValue: :UnitType::Pixels);
56 57
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // This preserves legacy behaviour originally defined when alt-text was mana ged by LayoutImage. 106 // This preserves legacy behaviour originally defined when alt-text was mana ged by LayoutImage.
106 if (noImageSourceSpecified(element)) 107 if (noImageSourceSpecified(element))
107 brokenImage->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone); 108 brokenImage->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
108 else 109 else
109 brokenImage->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInline); 110 brokenImage->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInline);
110 111
111 return newStyle; 112 return newStyle;
112 } 113 }
113 114
114 } // namespace blink 115 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698