third_party/WebKit/LayoutTests/hittesting/border-hittest-with-image-fallback.html - Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/hittesting/border-hittest-with-image-fallback.html

Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/inline-block/hittest-inline-block-with-abspos.html ('K') | « third_party/WebKit/LayoutTests/fast/inline-block/hittest-inline-block-with-abspos.html ('k') | third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>
	pdr. 2016/03/31 04:20:11 In your last reply you said "The new test(border-h In your last reply you said "The new test(border-hittest-with-image-fallback.html will be failed without this patch if we revert the patch at https://crrev.com/983693002 that made the early return in InlineBox.cpp." On my machine, this test passes in the following scenarios: * Without any patch * With https://crrev.com/983693002 reverted * With this patch and https://crrev.com/983693002 reverted * With this patch In what case does this test fail? Miyoung Shin(c) 2016/04/03 14:39:25 I'm really sorry but I missed to revert https://cr Show quoted text On 2016/03/31 04:20:11, pdr wrote: > In your last reply you said "The new > test(border-hittest-with-image-fallback.html will be failed without this patch > if we revert the patch at https://crrev.com/983693002 that made the early return > in InlineBox.cpp." > > On my machine, this test passes in the following scenarios: > * Without any patch > * With https://crrev.com/983693002 reverted > * With this patch and https://crrev.com/983693002 reverted > * With this patch > > In what case does this test fail? I'm really sorry but I missed to revert https://crrev.com/983693002 at the fourth patch. This is my test result. - PASS * Without any patch * With the fifth patch (= * With this patch and https://crrev.com/983693002 reverted) - Fail * With https://crrev.com/983693002 reverted * With the fifth patch except the C++ change in HTMLImageFallbackHelper.cpp
	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <style>

	5 img {

	6 background-color:red;

	7 border-radius: 50px;

	8 }

	9 </style>

	10 <body>

	11 <img id="roundedImg" src="none" width="100px" height="100px" />

	12 <div id="log"></div>

	13 </body>

	14 <script>

	15 test(function(t)

	16 {

	17 var element = document.getElementById("roundedImg");

	18 var x = element.offsetLeft + element.offsetWidth - 2;

	19 var y = element.offsetTop + element.offsetHeight - 2;

	20

	21 var element = document.elementFromPoint(x, y);

	22 assert_equals(element.nodeName, 'BODY');

	23 }, "elementFromPoint should return an element under a point that is clipped to a border-radius");

	24 </script>

OLD	NEW