third_party/WebKit/LayoutTests/fast/inline-block/hittest-inline-block-with-abspos.html - Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/inline-block/hittest-inline-block-with-abspos.html

Issue 1657483003: Add a border radius property to inherit it from a parent in a fallback content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/inline-block/hittest-child-of-inlineblock.html ('K') | « third_party/WebKit/LayoutTests/fast/inline-block/hittest-child-of-inlineblock.html ('k') | third_party/WebKit/LayoutTests/hittesting/border-hittest-with-image-fallback.html » ('j') | third_party/WebKit/LayoutTests/hittesting/border-hittest-with-image-fallback.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <style>

	5 #abs {

	6 position: absolute;

	7 top: 0px;

	8 left: 0px;

	9 visibility: hidden;
	pdr. 2016/03/31 04:20:11 What is this test testing? Which c++ line from thi What is this test testing? Which c++ line from this patch can we remove to make this test fail? Miyoung Shin(c) 2016/04/03 14:39:25 This is to prevent the regression that I made at h Show quoted text On 2016/03/31 04:20:11, pdr wrote: > What is this test testing? Which c++ line from this patch can we remove to make > this test fail? This is to prevent the regression that I made at https://crrev.com/1592413002. It was reverted. When I worked on that CL, I couldn't recognize regression because of lack of TC. I changed my approach comparing to that CL and I wanted to guarantee that new CL didn't create the regression. So we shouldn't get any test fail with/without this patch. (see https://bugs.chromium.org/p/chromium/issues/detail?id=568896#c11)
	10 }

	11 #abs-inner {

	12 width: 96px;

	13 height: 96px;

	14 display: inline-block;

	15 border-radius: 50%;

	16 }

	17 </style>

	18 <span id="inner"> Mouse over me! </span>

	19 <div id="abs"><div id="abs-inner"></div> </div>
	pdr. 2016/03/31 04:20:11 Nit: trailing whitespace Nit: trailing whitespace Miyoung Shin(c) 2016/04/03 14:39:25 Done. Show quoted text On 2016/03/31 04:20:11, pdr wrote: > Nit: trailing whitespace Done.
	20 <div id="log"></div>

	21 <script>

	22 test(function(t)

	23 {

	24 var element = document.getElementById("inner");

	25 var x = element.offsetLeft + element.offsetWidth / 2;

	26 var y = element.offsetTop + element.offsetHeight / 2;

	27

	28 var element = document.elementFromPoint(x, y);

	29 assert_equals(element.nodeName, 'SPAN');

	30 assert_equals(element.id, 'inner');

	31 }, "elementFromPoint should return an visible element under a point");

	32 </script>

OLD	NEW