Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1657463002: Element no longer implements AnalysisTarget Base URL: git@github.com:dart-lang/sdk.git@fixhash
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
index f869228ed281874ee95078848302594a3103e6ec..e0efaba18e0f475035c0042a9f0c56361de93c48 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
@@ -2065,7 +2065,9 @@ class _ElementOffsetUpdater extends GeneralizingElementVisitor {
// name offset
int nameOffset = element.nameOffset;
if (nameOffset > updateOffset) {
- cache.remove(element);
+ if (element is AnalysisTarget) {
+ cache.remove(element as AnalysisTarget);
Brian Wilkerson 2016/02/01 15:43:20 Is the cast necessary? I would have thought that t
+ }
(element as ElementImpl).nameOffset = nameOffset + updateDelta;
}
// visible range
@@ -2075,7 +2077,6 @@ class _ElementOffsetUpdater extends GeneralizingElementVisitor {
int newOffset = visibleRange.offset + updateDelta;
int length = visibleRange.length;
if (element is FunctionElementImpl) {
- cache.remove(element);
element.setVisibleRange(newOffset, length);
} else if (element is LocalVariableElementImpl) {
cache.remove(element);

Powered by Google App Engine
This is Rietveld 408576698