src/objects.cc - Issue 165743003: Don't turn objects with empty-string properties into fast-mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 165743003: Don't turn objects with empty-string properties into fast-mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 7360172e5b5d6a1036cd5af55e016b2dbb8a6567..e459332c76b47fd4b4d353d76655e7bfd5a2ddd7 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -15710,6 +15710,7 @@ MaybeObject* NameDictionary::TransformPropertiesToFastFor(

// instance descriptor.

MaybeObject* maybe_key = heap->InternalizeString(String::cast(k));

if (!maybe_key->To(&key)) return maybe_key;

+ if (key->Equals(heap->empty_string())) return this;

}

PropertyDetails details = DetailsAt(i);

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-fast-empty-string.js » ('j') | no next file with comments »