Issue 1657413002: Fix type of JavaException.cause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1657413002: Fix type of JavaException.cause. (Closed)

Created:
4 years, 10 months ago by Paul Berry

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix type of JavaException.cause. Not all thrown objects in Dart derive from `Exception`; in particular, errors such as NoSuchMethodError derive from `Error`, which is unrelated to `Exception`. So in order for `JavaException` to work with both, its `cause` field must have type `Object`. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ff180530ad7a0f68bbb56a7a1b132584f094ced8

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/java_core.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 10 months ago (2016-02-02 22:02:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff180530ad7a0f68bbb56a7a1b132584f094ced8 (presubmit successful).