Add VAND to the integrated ARM assembler.

src/IceInstARM32.cpp

 //===- subzero/src/IceInstARM32.cpp - ARM32 instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 615 matching lines @@
     break;
   case IceType_v16i8:
   case IceType_v8i16:
   case IceType_v4i32:
     Asm->vaddqi(typeElementType(DestTy), Dest, getSrc(0), getSrc(1));
     break;
   case IceType_v4f32:
     Asm->vaddqf(Dest, getSrc(0), getSrc(1));
     break;
   case IceType_f32:
-    Asm->vadds(getDest(), getSrc(0), getSrc(1), CondARM32::AL);
+    Asm->vadds(Dest, getSrc(0), getSrc(1), CondARM32::AL);
     break;
   case IceType_f64:
-    Asm->vaddd(getDest(), getSrc(0), getSrc(1), CondARM32::AL);
+    Asm->vaddd(Dest, getSrc(0), getSrc(1), CondARM32::AL);
     break;
   }
   assert(!Asm->needsTextFixup());
 }
 
 template <> void InstARM32Vand::emitIAS(const Cfg *Func) const {
   // TODO(kschimpf): add support for these instructions
-  emitUsingTextFixup(Func);
+  auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
+  const Variable *Dest = getDest();
+  Type DestTy = Dest->getType();

[Jim Stichnoth, 2016/02/02 18:46:44]

const

or just use "switch (Dest->getType())" like elsewhere.

[Karl, 2016/02/02 19:25:37]

Done.

+  switch (DestTy) {
+  case IceType_void:

[John, 2016/02/02 18:46:28]

defaut:?

[Karl, 2016/02/02 19:25:37]

Done.

+  case IceType_i1:
+  case IceType_i8:
+  case IceType_i16:
+  case IceType_i32:
+  case IceType_i64:
+  case IceType_f32:
+  case IceType_f64:
+  case IceType_v4f32:
+  case IceType_NUM:
+    llvm::report_fatal_error("Vand not defined on type " +
+                             std::string(typeString(DestTy)));

[Jim Stichnoth, 2016/02/02 18:46:44]

You're getting enough instances of std::string(typeString(...)) that it may be
time to add a new function in IceTypes.h:

  IceString typeIceString(Type Ty) { return std::string(typeString(Ty)); }

Or, typeString() could be redeclared to return IceString.

[Karl, 2016/02/02 19:25:37]

Done.

+    return;
+  case IceType_v4i1:
+  case IceType_v8i1:
+  case IceType_v16i1:
+  case IceType_v16i8:
+  case IceType_v8i16:
+  case IceType_v4i32:
+    Asm->vandq(Dest, getSrc(0), getSrc(1));
+  }
+  assert(!Asm->needsTextFixup());
 }
 
 template <> void InstARM32Vdiv::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
   const Variable *Dest = getDest();
   switch (Dest->getType()) {
   default:
     // TODO(kschimpf) Figure if more cases are needed.
     Asm->setNeedsTextFixup();
     break;
@@ skipping 1818 matching lines @@
 
 template class InstARM32FourAddrGPR<InstARM32::Mla>;
 template class InstARM32FourAddrGPR<InstARM32::Mls>;
 
 template class InstARM32CmpLike<InstARM32::Cmn>;
 template class InstARM32CmpLike<InstARM32::Cmp>;
 template class InstARM32CmpLike<InstARM32::Tst>;
 
 } // end of namespace ARM32
 } // end of namespace Ice