Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1657303003: [UMA, Android, MediaFling] Record the domain and registry of the frame url when casting. (Closed)

Created:
4 years, 10 months ago by whywhat
Modified:
4 years, 10 months ago
Reviewers:
aberent, Steven Holte
CC:
asvitkine+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, Mark P
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UMA, Android, MediaFling] Record the domain and registry of the frame url when casting. BUG=583338 TEST=manual Committed: https://crrev.com/98a34e1189bf20d1872f9e723b44076b0edd45bf Cr-Commit-Position: refs/heads/master@{#373235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/RecordCastAction.java View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
whywhat
Please, take a look. Anthony: overall change Mark: rappor.xml Thanks!
4 years, 10 months ago (2016-02-02 16:43:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657303003/1
4 years, 10 months ago (2016-02-02 16:46:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 17:43:22 UTC) #6
Mark P
Please have holte@ review rappor changes if possible, even rappor.xml changes (so he's aware how ...
4 years, 10 months ago (2016-02-02 18:11:04 UTC) #7
whywhat
Thanks Mark, sure! Steven, could you review the rappor.xml change, please.
4 years, 10 months ago (2016-02-02 20:09:42 UTC) #9
Steven Holte
lgtm
4 years, 10 months ago (2016-02-03 03:49:46 UTC) #10
aberent
lgtm
4 years, 10 months ago (2016-02-03 14:00:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657303003/1
4 years, 10 months ago (2016-02-03 14:43:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 14:49:28 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 14:50:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98a34e1189bf20d1872f9e723b44076b0edd45bf
Cr-Commit-Position: refs/heads/master@{#373235}

Powered by Google App Engine
This is Rietveld 408576698