Issue 16573: Fixed build with no ENABLE_LOGGING_AND_PROFILING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16573: Fixed build with no ENABLE_LOGGING_AND_PROFILING (Closed)

Created:
11 years, 11 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Fixed build with no ENABLE_LOGGING_AND_PROFILING

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	src/codegen.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/codegen-arm.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/log.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/log.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

On 2009/01/07 14:16:51, Christian Plesner Hansen wrote: > LGTM - should flexo have a builder ...

11 years, 11 months ago (2009-01-07 14:22:02 UTC) #2

Søren Thygesen Gjesse

11 years, 11 months ago (2009-01-07 14:22:09 UTC) #3

http://codereview.chromium.org/16573/diff/1/8
File src/log.h (right):

http://codereview.chromium.org/16573/diff/1/8#newcode205
Line 205: #endif
This #endif (for #ifdef ENABLE_LOGGING_AND_PROFILING) is immediately followed by
a new #ifdef ENABLE_LOGGING_AND_PROFILING...

Expand Messages | Collapse Messages