Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1657233002: SafeBrowsing: Create a custom histogram enum for V4 GetHash results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sb-v4-4
Patch Set: Remove TODO Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6ef1418e830770d0db797bfe4775f3d024b0c155..e017c3a93af4706e68dc367bb54af74244edaa9d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -40689,18 +40689,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="SafeBrowsing.GetV4HashResult" enum="SB2GetHashResult">
+<histogram name="SafeBrowsing.GetV4HashResult"
+ enum="SafeBrowsingGetV4HashResult">
<owner>kcarattini@chromium.org</owner>
<summary>
- Track return status from V4 GetHash attempts (STATUS_200, STATUS_204,
- NETWORK_ERROR, HTTP_ERROR, BACKOFF_ERROR, PARSE_ERROR, NETWORK_ERROR,
- HTTP_ERROR, BACKOFF_ERROR and MIN_WAIT_DURATION_ERROR), whether parsing a
- 200 result failed (PARSE_ERROR), and dispensation of returned values (EMPTY,
- HIT, MISS). EMPTY means the response had no full hashes, and should contain
- all of the 204 responses plus all *_ERROR cases. HIT means that one of the
- full hashes matched. MISS means that none of the hashes matched (there was a
- prefix collision). The buckets of this histogram overlap, so the counts
- cannot be used as percentages.
+ Track return status from V4 GetHash attempts. The buckets of this histogram
+ overlap, so the counts cannot be used as percentages.
</summary>
</histogram>
@@ -76408,6 +76402,15 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Kill (He's dead, Jim!)"/>
</enum>
+<enum name="SafeBrowsingGetV4HashResult" type="int">
+ <int value="0" label="STATUS_200"/>
+ <int value="1" label="PARSE_ERROR (subset of STATUS_200)"/>
+ <int value="2" label="NETWORK_ERROR"/>
+ <int value="3" label="HTTP_ERROR"/>
+ <int value="4" label="BACKOFF_ERROR"/>
+ <int value="5" label="MIN_WAIT_DURATION_ERROR"/>
+</enum>
+
<enum name="SafeBrowsingParseV4HashResult" type="int">
<int value="0" label="PARSE_FROM_STRING_ERROR"/>
<int value="1" label="UNEXPECTED_THREAT_ENTRY_TYPE_ERROR"/>

Powered by Google App Engine
This is Rietveld 408576698