Move signal_blocker to platform and use it by default in TEMP_FAILURE_RETRY.

runtime/bin/socket_linux.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_LINUX)
 
 #include <errno.h>  // NOLINT
 #include <stdio.h>  // NOLINT
 #include <stdlib.h>  // NOLINT
 #include <string.h>  // NOLINT
 #include <sys/stat.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 #include <net/if.h>  // NOLINT
 #include <netinet/tcp.h>  // NOLINT
 #include <ifaddrs.h>  // NOLINT
 
 #include "bin/fdutils.h"
 #include "bin/file.h"
 #include "bin/log.h"
-#include "bin/signal_blocker.h"
 #include "bin/socket.h"
+#include "platform/signal_blocker.h"
 #include "vm/thread.h"
 
 
 namespace dart {
 namespace bin {
 
 SocketAddress::SocketAddress(struct sockaddr* sa) {
   ASSERT(INET6_ADDRSTRLEN >= INET_ADDRSTRLEN);
   if (!Socket::FormatNumericAddress(
           reinterpret_cast<RawAddr*>(sa), as_string_, INET6_ADDRSTRLEN)) {
     as_string_[0] = 0;
   }
   socklen_t salen = GetAddrLength(reinterpret_cast<RawAddr*>(sa));
   memmove(reinterpret_cast<void *>(&addr_), sa, salen);
 }
 
 
 bool Socket::FormatNumericAddress(RawAddr* addr, char* address, int len) {
   socklen_t salen = SocketAddress::GetAddrLength(addr);
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getnameinfo(&addr->addr,
-                                     salen,
-                                     address,
-                                     len,
-                                     NULL,
-                                     0,
-                                     NI_NUMERICHOST)) != 0) {
+  if (getnameinfo(
+        &addr->addr, salen, address, len, NULL, 0, NI_NUMERICHOST) != 0) {
     return false;
   }
   return true;
 }
 
 
 bool Socket::Initialize() {
   // Nothing to do on Linux.
   return true;
 }
 
 
 intptr_t Socket::Create(RawAddr addr) {
   intptr_t fd;
-  fd = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(socket(
-      addr.ss.ss_family, SOCK_STREAM | SOCK_NONBLOCK | SOCK_CLOEXEC, 0));
+  fd = socket(addr.ss.ss_family, SOCK_STREAM | SOCK_NONBLOCK | SOCK_CLOEXEC, 0);
   if (fd < 0) {
     const int kBufferSize = 1024;
     char error_buf[kBufferSize];
     Log::PrintErr("Error Create: %s\n",
                   strerror_r(errno, error_buf, kBufferSize));
     return -1;
   }
   return fd;
 }
 
 
 intptr_t Socket::Connect(intptr_t fd, RawAddr addr, const intptr_t port) {
   SocketAddress::SetAddrPort(&addr, port);
-  intptr_t result = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-      connect(fd,
-              &addr.addr,
-              SocketAddress::GetAddrLength(&addr)));
+  intptr_t result = TEMP_FAILURE_RETRY(
+      connect(fd, &addr.addr, SocketAddress::GetAddrLength(&addr)));
   if (result == 0 || errno == EINPROGRESS) {
     return fd;
   }
-  VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+  VOID_TEMP_FAILURE_RETRY(close(fd));
   return -1;
 }
 
 
 intptr_t Socket::CreateConnect(RawAddr addr, const intptr_t port) {
   intptr_t fd = Socket::Create(addr);
   if (fd < 0) {
     return fd;
   }
   return Socket::Connect(fd, addr, port);
 }
 
 
 intptr_t Socket::Available(intptr_t fd) {
   return FDUtils::AvailableBytes(fd);
 }
 
 
 int Socket::Read(intptr_t fd, void* buffer, intptr_t num_bytes) {
   ASSERT(fd >= 0);
-  ssize_t read_bytes = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(read(fd, buffer,
-                                                             num_bytes));
+  ssize_t read_bytes = TEMP_FAILURE_RETRY(read(fd, buffer, num_bytes));
   ASSERT(EAGAIN == EWOULDBLOCK);
   if (read_bytes == -1 && errno == EWOULDBLOCK) {
     // If the read would block we need to retry and therefore return 0
     // as the number of bytes written.
     read_bytes = 0;
   }
   return read_bytes;
 }
 
 
 int Socket::RecvFrom(intptr_t fd, void* buffer, intptr_t num_bytes,
                      RawAddr* addr) {
   ASSERT(fd >= 0);
   socklen_t addr_len = sizeof(addr->ss);
-  ssize_t read_bytes =
-      TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          recvfrom(fd, buffer, num_bytes, 0, &addr->addr, &addr_len));
+  ssize_t read_bytes = TEMP_FAILURE_RETRY(
+      recvfrom(fd, buffer, num_bytes, 0, &addr->addr, &addr_len));
   if (read_bytes == -1 && errno == EWOULDBLOCK) {
     // If the read would block we need to retry and therefore return 0
     // as the number of bytes written.
     read_bytes = 0;
   }
   return read_bytes;
 }
 
 
 int Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {
   ASSERT(fd >= 0);
-  ssize_t written_bytes = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(write(fd, buffer,
-                                                                 num_bytes));
+  ssize_t written_bytes = TEMP_FAILURE_RETRY(write(fd, buffer, num_bytes));
   ASSERT(EAGAIN == EWOULDBLOCK);
   if (written_bytes == -1 && errno == EWOULDBLOCK) {
     // If the would block we need to retry and therefore return 0 as
     // the number of bytes written.
     written_bytes = 0;
   }
   return written_bytes;
 }
 
 
 int Socket::SendTo(intptr_t fd, const void* buffer, intptr_t num_bytes,
                    RawAddr addr) {
   ASSERT(fd >= 0);
-  ssize_t written_bytes =
-      TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          sendto(fd, buffer, num_bytes, 0,
-                 &addr.addr, SocketAddress::GetAddrLength(&addr)));
+  ssize_t written_bytes = TEMP_FAILURE_RETRY(
+      sendto(fd, buffer, num_bytes, 0,
+          &addr.addr, SocketAddress::GetAddrLength(&addr)));
   ASSERT(EAGAIN == EWOULDBLOCK);
   if (written_bytes == -1 && errno == EWOULDBLOCK) {
     // If the would block we need to retry and therefore return 0 as
     // the number of bytes written.
     written_bytes = 0;
   }
   return written_bytes;
 }
 
 
 intptr_t Socket::GetPort(intptr_t fd) {
   ASSERT(fd >= 0);
   RawAddr raw;
   socklen_t size = sizeof(raw);
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          getsockname(fd,
-                      &raw.addr,
-                      &size))) {
+  if (getsockname(fd, &raw.addr, &size)) {
     const int kBufferSize = 1024;
     char error_buf[kBufferSize];
     Log::PrintErr("Error getsockname: %s\n",
                   strerror_r(errno, error_buf, kBufferSize));
     return 0;
   }
   return SocketAddress::GetAddrPort(&raw);
 }
 
 
 SocketAddress* Socket::GetRemotePeer(intptr_t fd, intptr_t* port) {
   ASSERT(fd >= 0);
   RawAddr raw;
   socklen_t size = sizeof(raw);
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          getpeername(fd,
-                      &raw.addr,
-                      &size))) {
+  if (getpeername(fd, &raw.addr, &size)) {
     const int kBufferSize = 1024;
     char error_buf[kBufferSize];
     Log::PrintErr("Error getpeername: %s\n",
                   strerror_r(errno, error_buf, kBufferSize));
     return NULL;
   }
   *port = SocketAddress::GetAddrPort(&raw);
   return new SocketAddress(&raw.addr);
 }
 
@@ skipping 67 matching lines @@
   freeaddrinfo(info);
   return addresses;
 }
 
 
 bool Socket::ReverseLookup(RawAddr addr,
                            char* host,
                            intptr_t host_len,
                            OSError** os_error) {
   ASSERT(host_len >= NI_MAXHOST);
-  int status = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getnameinfo(
+  int status = getnameinfo(
       &addr.addr,
       SocketAddress::GetAddrLength(&addr),
       host,
       host_len,
       NULL,
       0,
-      NI_NAMEREQD));
+      NI_NAMEREQD);
   if (status != 0) {
     ASSERT(*os_error == NULL);
     *os_error = new OSError(status,
                             gai_strerror(status),
                             OSError::kGetAddressInfo);
     return false;
   }
   return true;
 }
 
 
 bool Socket::ParseAddress(int type, const char* address, RawAddr* addr) {
   int result;
   if (type == SocketAddress::TYPE_IPV4) {
     result = inet_pton(AF_INET, address, &addr->in.sin_addr);
   } else {
     ASSERT(type == SocketAddress::TYPE_IPV6);
     result = inet_pton(AF_INET6, address, &addr->in6.sin6_addr);
   }
   return result == 1;
 }
 
 
 intptr_t Socket::CreateBindDatagram(
     RawAddr* addr, intptr_t port, bool reuseAddress) {
   intptr_t fd;
 
-  fd = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(socket(
-      addr->addr.sa_family,
-      SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK,
-      IPPROTO_UDP));
+  fd = socket(addr->addr.sa_family,
+              SOCK_DGRAM | SOCK_CLOEXEC | SOCK_NONBLOCK,
+              IPPROTO_UDP);
   if (fd < 0) return -1;
 
   if (reuseAddress) {
     int optval = 1;
-    VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-        setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval)));
+    setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval));
   }
 
   SocketAddress::SetAddrPort(addr, port);
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          bind(fd,
-               &addr->addr,
-               SocketAddress::GetAddrLength(addr))) < 0) {
-    TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+  if (bind(fd, &addr->addr, SocketAddress::GetAddrLength(addr)) < 0) {
+    TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
   return fd;
 }
 
 
 static bool ShouldIncludeIfaAddrs(struct ifaddrs* ifa, int lookup_family) {
   if (ifa->ifa_addr == NULL) {
     // OpenVPN's virtual device tun0.
     return false;
@@ skipping 43 matching lines @@
   return addresses;
 }
 
 
 intptr_t ServerSocket::CreateBindListen(RawAddr addr,
                                         intptr_t port,
                                         intptr_t backlog,
                                         bool v6_only) {
   intptr_t fd;
 
-  fd = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(socket(
-      addr.ss.ss_family, SOCK_STREAM | SOCK_CLOEXEC | SOCK_NONBLOCK, 0));
+  fd = socket(addr.ss.ss_family, SOCK_STREAM | SOCK_CLOEXEC | SOCK_NONBLOCK, 0);
   if (fd < 0) return -1;
 
   int optval = 1;
-  TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-      setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval)));
+  setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval));
 
   if (addr.ss.ss_family == AF_INET6) {
     optval = v6_only ? 1 : 0;
-    TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-        setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &optval, sizeof(optval)));
+    setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &optval, sizeof(optval));
   }
 
   SocketAddress::SetAddrPort(&addr, port);
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-          bind(fd,
-               &addr.addr,
-               SocketAddress::GetAddrLength(&addr))) < 0) {
-    VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+  if (bind(fd, &addr.addr, SocketAddress::GetAddrLength(&addr)) < 0) {
+    VOID_TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
 
   // Test for invalid socket port 65535 (some browsers disallow it).
   if (port == 0 && Socket::GetPort(fd) == 65535) {
     // Don't close the socket until we have created a new socket, ensuring
     // that we do not get the bad port number again.
     intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only);
     int err = errno;
-    VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+    VOID_TEMP_FAILURE_RETRY(close(fd));
     errno = err;
     return new_fd;
   }
 
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(
-        listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) {
-    VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+  if (listen(fd, backlog > 0 ? backlog : SOMAXCONN) != 0) {
+    VOID_TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
 
   return fd;
 }
 
 
 static bool IsTemporaryAcceptError(int error) {
   // On Linux a number of protocol errors should be treated as EAGAIN.
   // These are the ones for TCP/IP.
   return (error == EAGAIN) || (error == ENETDOWN) || (error == EPROTO) ||
       (error == ENOPROTOOPT) || (error == EHOSTDOWN) || (error == ENONET) ||
       (error == EHOSTUNREACH) || (error == EOPNOTSUPP) ||
       (error == ENETUNREACH);
 }
 
 
 intptr_t ServerSocket::Accept(intptr_t fd) {
   intptr_t socket;
   struct sockaddr clientaddr;
   socklen_t addrlen = sizeof(clientaddr);
-  socket = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(accept4(
-        fd, &clientaddr, &addrlen, SOCK_NONBLOCK | SOCK_CLOEXEC));
+  socket = TEMP_FAILURE_RETRY(accept4(
+      fd, &clientaddr, &addrlen, SOCK_NONBLOCK | SOCK_CLOEXEC));
   if (socket == -1) {
     if (IsTemporaryAcceptError(errno)) {
       // We need to signal to the caller that this is actually not an
       // error. We got woken up from the poll on the listening socket,
       // but there is no connection ready to be accepted.
       ASSERT(kTemporaryFailure != -1);
       socket = kTemporaryFailure;
     }
   }
   return socket;
 }
 
 
 void Socket::Close(intptr_t fd) {
   ASSERT(fd >= 0);
-  int err = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(close(fd));
+  int err = TEMP_FAILURE_RETRY(close(fd));
   if (err != 0) {
     const int kBufferSize = 1024;
     char error_buf[kBufferSize];
     Log::PrintErr("%s\n", strerror_r(errno, error_buf, kBufferSize));
   }
 }
 
 
 bool Socket::GetNoDelay(intptr_t fd, bool* enabled) {
   int on;
   socklen_t len = sizeof(on);
-  int err = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getsockopt(fd,
-                                          IPPROTO_TCP,
-                                          TCP_NODELAY,
-                                          reinterpret_cast<void *>(&on),
-                                          &len));
+  int err = getsockopt(
+      fd, IPPROTO_TCP, TCP_NODELAY, reinterpret_cast<void *>(&on), &len);
   if (err == 0) {
     *enabled = on == 1;
   }
   return err == 0;
 }
 
 
 bool Socket::SetNoDelay(intptr_t fd, bool enabled) {
   int on = enabled ? 1 : 0;
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(fd,
-                                       IPPROTO_TCP,
-                                       TCP_NODELAY,
-                                       reinterpret_cast<char *>(&on),
-                                       sizeof(on))) == 0;
+  return setsockopt(fd,
+                    IPPROTO_TCP,
+                    TCP_NODELAY,
+                    reinterpret_cast<char *>(&on),
+                    sizeof(on)) == 0;
 }
 
 
 bool Socket::GetMulticastLoop(intptr_t fd, intptr_t protocol, bool* enabled) {
   uint8_t on;
   socklen_t len = sizeof(on);
   int level = protocol == SocketAddress::TYPE_IPV4 ? IPPROTO_IP : IPPROTO_IPV6;
   int optname = protocol == SocketAddress::TYPE_IPV4
       ? IP_MULTICAST_LOOP : IPV6_MULTICAST_LOOP;
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getsockopt(fd,
-                                     level,
-                                     optname,
-                                     reinterpret_cast<char *>(&on),
-                                    &len)) == 0) {
+  if (getsockopt(
+        fd, level, optname, reinterpret_cast<char *>(&on), &len) == 0) {
     *enabled = (on == 1);
     return true;
   }
   return false;
 }
 
 
 bool Socket::SetMulticastLoop(intptr_t fd, intptr_t protocol, bool enabled) {
   int on = enabled ? 1 : 0;
   int level = protocol == SocketAddress::TYPE_IPV4 ? IPPROTO_IP : IPPROTO_IPV6;
   int optname = protocol == SocketAddress::TYPE_IPV4
       ? IP_MULTICAST_LOOP : IPV6_MULTICAST_LOOP;
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(fd,
-                                       level,
-                                       optname,
-                                       reinterpret_cast<char *>(&on),
-                                       sizeof(on))) == 0;
+  return setsockopt(
+      fd, level, optname, reinterpret_cast<char *>(&on), sizeof(on)) == 0;
 }
 
 
 bool Socket::GetMulticastHops(intptr_t fd, intptr_t protocol, int* value) {
   uint8_t v;
   socklen_t len = sizeof(v);
   int level = protocol == SocketAddress::TYPE_IPV4 ? IPPROTO_IP : IPPROTO_IPV6;
   int optname = protocol == SocketAddress::TYPE_IPV4
       ? IP_MULTICAST_TTL : IPV6_MULTICAST_HOPS;
-  if (TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getsockopt(fd,
-                                    level,
-                                    optname,
-                                    reinterpret_cast<char *>(&v),
-                                    &len)) == 0) {
+  if (getsockopt(fd, level, optname, reinterpret_cast<char *>(&v), &len) == 0) {
     *value = v;
     return true;
   }
   return false;
 }
 
 
 bool Socket::SetMulticastHops(intptr_t fd, intptr_t protocol, int value) {
   int v = value;
   int level = protocol == SocketAddress::TYPE_IPV4 ? IPPROTO_IP : IPPROTO_IPV6;
   int optname = protocol == SocketAddress::TYPE_IPV4
       ? IP_MULTICAST_TTL : IPV6_MULTICAST_HOPS;
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(fd,
-                                       level,
-                                       optname,
-                                       reinterpret_cast<char *>(&v),
-                                       sizeof(v))) == 0;
+  return setsockopt(
+      fd, level, optname, reinterpret_cast<char *>(&v), sizeof(v)) == 0;
 }
 
 
 bool Socket::GetBroadcast(intptr_t fd, bool* enabled) {
   int on;
   socklen_t len = sizeof(on);
-  int err = TEMP_FAILURE_RETRY_BLOCK_SIGNALS(getsockopt(fd,
-                                          SOL_SOCKET,
-                                          SO_BROADCAST,
-                                          reinterpret_cast<char *>(&on),
-                                          &len));
+  int err = getsockopt(
+      fd, SOL_SOCKET, SO_BROADCAST, reinterpret_cast<char *>(&on), &len);
   if (err == 0) {
     *enabled = on == 1;
   }
   return err == 0;
 }
 
 
 bool Socket::SetBroadcast(intptr_t fd, bool enabled) {
   int on = enabled ? 1 : 0;
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(fd,
-                                       SOL_SOCKET,
-                                       SO_BROADCAST,
-                                       reinterpret_cast<char *>(&on),
-                                       sizeof(on))) == 0;
+  return setsockopt(fd,
+                    SOL_SOCKET,
+                    SO_BROADCAST,
+                    reinterpret_cast<char *>(&on),
+                    sizeof(on)) == 0;
 }
 
 
 bool Socket::JoinMulticast(
     intptr_t fd, RawAddr* addr, RawAddr*, int interfaceIndex) {
   int proto = addr->addr.sa_family == AF_INET ? IPPROTO_IP : IPPROTO_IPV6;
   struct group_req mreq;
   mreq.gr_interface = interfaceIndex;
   memmove(&mreq.gr_group, &addr->ss, SocketAddress::GetAddrLength(addr));
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(
-      fd, proto, MCAST_JOIN_GROUP, &mreq, sizeof(mreq))) == 0;
+  return setsockopt(fd, proto, MCAST_JOIN_GROUP, &mreq, sizeof(mreq)) == 0;
 }
 
 
 bool Socket::LeaveMulticast(
     intptr_t fd, RawAddr* addr, RawAddr*, int interfaceIndex) {
   int proto = addr->addr.sa_family == AF_INET ? IPPROTO_IP : IPPROTO_IPV6;
   struct group_req mreq;
   mreq.gr_interface = interfaceIndex;
   memmove(&mreq.gr_group, &addr->ss, SocketAddress::GetAddrLength(addr));
-  return TEMP_FAILURE_RETRY_BLOCK_SIGNALS(setsockopt(
-      fd, proto, MCAST_LEAVE_GROUP, &mreq, sizeof(mreq))) == 0;
+  return setsockopt(fd, proto, MCAST_LEAVE_GROUP, &mreq, sizeof(mreq)) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_LINUX)