Cast: Implemented size limiting and event filtering in EncodingEventSubscriber.

media/cast/logging/logging_defines.cc

Index: media/cast/logging/logging_defines.cc
diff --git a/media/cast/logging/logging_defines.cc b/media/cast/logging/logging_defines.cc
index d59c045e0e972917a01702df48d35b78221bab98..af71ff74c85a940f2eb6d557d5030846abaead67 100644
--- a/media/cast/logging/logging_defines.cc
+++ b/media/cast/logging/logging_defines.cc
@@ -72,6 +72,45 @@ std::string CastLoggingToString(CastLoggingEvent event) {
   return "";
 }
 
+EventMediaType GetEventMediaType(CastLoggingEvent event) {
+  switch (event) {
+    case kUnknown:

[Alpha Left Google, 2014/02/14 18:42:39]

From kUnoknown to kRembBitrate they are not something we care to keep for
debugging. RttMs kPacketLoss, kJitterMs can all be computed from existing audio
and video events. kRembBitrate has little use.

I don't think we need to care about OTHER_EVENT.

[imcheng, 2014/02/14 20:24:17]

Ack. The other 4 here (kPacketSentToPacer, kPacketSentToNetwork,
kPacketRetransmitted, kDuplicatePacketReceived) need to be split so that they
are video/audio events. The first 3 are not even being logged yet - filing a bug
for that. The last one I have already taken care of and the patch landed this
morning, so I will rebase and make the change here.

+    case kRttMs:
+    case kPacketLoss:
+    case kJitterMs:
+    case kRembBitrate:
+    // TODO(imcheng): These need to be split into video/audio events.
+    case kPacketSentToPacer:
+    case kPacketSentToNetwork:
+    case kPacketRetransmitted:
+    case kDuplicatePacketReceived:
+      return OTHER_EVENT;
+    case kAudioAckSent:
+    case kAudioFrameReceived:
+    case kAudioFrameCaptured:
+    case kAudioFrameEncoded:
+    case kAudioPlayoutDelay:
+    case kAudioFrameDecoded:
+    case kAudioPacketReceived:
+      return AUDIO_EVENT;
+    case kVideoAckReceived:
+    case kVideoAckSent:
+    case kVideoFrameCaptured:
+    case kVideoFrameReceived:
+    case kVideoFrameSentToEncoder:
+    case kVideoFrameEncoded:
+    case kVideoFrameDecoded:
+    case kVideoRenderDelay:
+    case kVideoPacketReceived:
+      return VIDEO_EVENT;
+    case kNumOfLoggingEvents:
+      NOTREACHED();
+      return OTHER_EVENT;
+  }
+  NOTREACHED();
+  return OTHER_EVENT;
+}
+
 FrameEvent::FrameEvent()
     : rtp_timestamp(0u), frame_id(kFrameIdUnknown), size(0u), type(kUnknown) {}
 FrameEvent::~FrameEvent() {}