Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1657213002: [turbofan] Constant-fold ToNumber conversions. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Constant-fold ToNumber conversions. We can constant-fold JSToNumber conversions during typed lowering if the input is a known primitive constant (i.e. a string, oddball or number). I.e. JSToNumber("123") can be constant-folded to 123. R=jarin@chromium.org Committed: https://crrev.com/1f85ff077d90cac6e2d57a4d5234f760436cbe55 Cr-Commit-Position: refs/heads/master@{#33654}

Patch Set 1 #

Patch Set 2 : Preserve identity of ToNumber w/ number nodes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 05:40:12 UTC) #1
Benedikt Meurer
Hey Jaro, Simple optimization for JSToNumber. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-02 05:40:53 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-02 06:25:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657213002/20001
4 years, 10 months ago (2016-02-02 06:40:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 07:01:50 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 07:02:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f85ff077d90cac6e2d57a4d5234f760436cbe55
Cr-Commit-Position: refs/heads/master@{#33654}

Powered by Google App Engine
This is Rietveld 408576698