Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: runtime/vm/weak_code.cc

Issue 1657153002: Clean up global variables related to precompilation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fixed unnecessary includes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/weak_code.h" 5 #include "vm/weak_code.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
11 #include "vm/compiler.h"
12 #include "vm/object.h" 11 #include "vm/object.h"
13 #include "vm/stack_frame.h" 12 #include "vm/stack_frame.h"
14 13
15 namespace dart { 14 namespace dart {
16 15
16 DECLARE_FLAG(bool, precompilation);
17
17 bool WeakCodeReferences::HasCodes() const { 18 bool WeakCodeReferences::HasCodes() const {
18 return !array_.IsNull() && (array_.Length() > 0); 19 return !array_.IsNull() && (array_.Length() > 0);
19 } 20 }
20 21
21 22
22 void WeakCodeReferences::Register(const Code& value) { 23 void WeakCodeReferences::Register(const Code& value) {
23 if (!array_.IsNull()) { 24 if (!array_.IsNull()) {
24 // Try to find and reuse cleared WeakProperty to avoid allocating new one. 25 // Try to find and reuse cleared WeakProperty to avoid allocating new one.
25 WeakProperty& weak_property = WeakProperty::Handle(); 26 WeakProperty& weak_property = WeakProperty::Handle();
26 for (intptr_t i = 0; i < array_.Length(); i++) { 27 for (intptr_t i = 0; i < array_.Length(); i++) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 return false; 61 return false;
61 } 62 }
62 63
63 64
64 void WeakCodeReferences::DisableCode() { 65 void WeakCodeReferences::DisableCode() {
65 IncrementInvalidationGen(); 66 IncrementInvalidationGen();
66 const Array& code_objects = Array::Handle(array_.raw()); 67 const Array& code_objects = Array::Handle(array_.raw());
67 if (code_objects.IsNull()) { 68 if (code_objects.IsNull()) {
68 return; 69 return;
69 } 70 }
70 ASSERT(Compiler::allow_recompilation()); 71 ASSERT(!FLAG_precompilation);
71 UpdateArrayTo(Object::null_array()); 72 UpdateArrayTo(Object::null_array());
72 // Disable all code on stack. 73 // Disable all code on stack.
73 Code& code = Code::Handle(); 74 Code& code = Code::Handle();
74 { 75 {
75 DartFrameIterator iterator; 76 DartFrameIterator iterator;
76 StackFrame* frame = iterator.NextFrame(); 77 StackFrame* frame = iterator.NextFrame();
77 while (frame != NULL) { 78 while (frame != NULL) {
78 code = frame->LookupDartCode(); 79 code = frame->LookupDartCode();
79 if (IsOptimizedCode(code_objects, code)) { 80 if (IsOptimizedCode(code_objects, code)) {
80 ReportDeoptimization(code); 81 ReportDeoptimization(code);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 // Make non-OSR code non-entrant. 130 // Make non-OSR code non-entrant.
130 if (!code.IsDisabled()) { 131 if (!code.IsDisabled()) {
131 ReportSwitchingCode(code); 132 ReportSwitchingCode(code);
132 code.DisableDartCode(); 133 code.DisableDartCode();
133 } 134 }
134 } 135 }
135 } 136 }
136 } 137 }
137 138
138 } // namespace dart 139 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698