Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1657153002: Clean up global variables related to precompilation. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up global variables related to precompilation. Replace always_optimize_ and allow_recompilation_ with FLAG_precompilation and !FLAG_precompilation. They are equivalent and set only once according to the --precompilation flag BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d76fe1eacd91b354da1c8c9595f0fdc4bd5b2519

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -77 lines) Patch
M runtime/vm/code_descriptors.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/compiler.h View 1 chunk +1 line, -16 lines 0 comments Download
M runtime/vm/compiler.cc View 9 chunks +11 lines, -13 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/weak_code.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 10 months ago (2016-02-02 01:00:20 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/1657153002/diff/1/runtime/vm/code_descriptors.cc File runtime/vm/code_descriptors.cc (right): https://codereview.chromium.org/1657153002/diff/1/runtime/vm/code_descriptors.cc#newcode6 runtime/vm/code_descriptors.cc:6: #include "vm/compiler.h" Include no longer needed
4 years, 10 months ago (2016-02-02 01:15:25 UTC) #4
Florian Schneider
https://codereview.chromium.org/1657153002/diff/1/runtime/vm/code_descriptors.cc File runtime/vm/code_descriptors.cc (right): https://codereview.chromium.org/1657153002/diff/1/runtime/vm/code_descriptors.cc#newcode6 runtime/vm/code_descriptors.cc:6: #include "vm/compiler.h" On 2016/02/02 01:15:25, rmacnak wrote: > Include ...
4 years, 10 months ago (2016-02-02 02:23:01 UTC) #5
Florian Schneider
4 years, 10 months ago (2016-02-02 03:11:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d76fe1eacd91b354da1c8c9595f0fdc4bd5b2519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698