Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/BUILD.gn

Issue 1657143002: [GN] Guard the "pangocairo" config with (use_pango || use_cairo). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Guard another pango target Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/linux/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 96bb583ae3b3c20531330cf38cac5260e17f230b..983d30fc405625f0090af91e43f44215a8962e78 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -191,13 +191,15 @@ if (!is_android) {
":xdg_mime", # Needs to be public for installer to consume files.
]
- # Needed for chrome_main.cc initialization of libraries.
- configs += [ "//build/config/linux:pangocairo" ]
-
# GYP has this in a 'profiling==0 and linux_disable_pie==0' condition.
# but GN doesn't have either of these flags.
ldflags = [ "-pie" ]
+ if (use_pango || use_cairo) {
+ # Needed for chrome_main.cc initialization of libraries.
+ configs += [ "//build/config/linux:pangocairo" ]
+ }
+
if (use_x11) {
configs += [
"//build/config/linux:x11",
« no previous file with comments | « build/config/linux/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698