Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1657143002: [GN] Guard the "pangocairo" config with (use_pango || use_cairo). (Closed)

Created:
4 years, 10 months ago by slan
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, dpranke, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Guard the "pangocairo" config with (use_pango || use_cairo). To avoid breakge on platforms that don't support cairo or pango, the declaration of the "pangocairo" pkg-config target should be guarded by these feature flags. Also update offending callsites. BUG= b/26908482 Committed: https://crrev.com/a08ad8436ec87b7018facc26e535c3788d5de73f Cr-Commit-Position: refs/heads/master@{#372956}

Patch Set 1 #

Patch Set 2 : Guard another pango target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M build/config/linux/BUILD.gn View 1 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
slan
+sky@ for chrome/OWNERS +dpranke@ for build/config OWNERS Dirk and Scott, We're seeing some of our ...
4 years, 10 months ago (2016-02-02 00:46:54 UTC) #2
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-02 00:54:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657143002/20001
4 years, 10 months ago (2016-02-02 00:59:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 02:02:28 UTC) #8
sky
LGTM
4 years, 10 months ago (2016-02-02 04:20:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657143002/20001
4 years, 10 months ago (2016-02-02 16:00:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 16:15:05 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 16:17:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a08ad8436ec87b7018facc26e535c3788d5de73f
Cr-Commit-Position: refs/heads/master@{#372956}

Powered by Google App Engine
This is Rietveld 408576698