Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/libwebp/BUILD.gn

Issue 1657113002: libwebp: use -O2 on arm targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: relocate gn config manipulation Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libwebp/BUILD.gn
diff --git a/third_party/libwebp/BUILD.gn b/third_party/libwebp/BUILD.gn
index e53ce28d6cacb598c3a955719b2780f8802ba899..676a5d1d7bd3fe8f40c8905d663a7055ed8b63ec 100644
--- a/third_party/libwebp/BUILD.gn
+++ b/third_party/libwebp/BUILD.gn
@@ -9,6 +9,9 @@ config("libwebp_config") {
include_dirs = [ "." ]
}
+set_opt_level =
+ !is_debug && is_posix && (current_cpu == "arm" || current_cpu == "arm64")
+
use_dsp_neon =
current_cpu == "arm64" || (current_cpu == "arm" && arm_version >= 7 &&
(arm_use_neon || arm_optionally_use_neon))
@@ -29,6 +32,10 @@ source_set("libwebp_dec") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
deps = [
":libwebp_dsp",
@@ -88,6 +95,10 @@ source_set("libwebp_dsp") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
all_dependent_configs = [ ":libwebp_config" ]
deps = [
@@ -118,6 +129,10 @@ source_set("libwebp_dsp_sse41") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
all_dependent_configs = [ ":libwebp_config" ]
if (!is_msan) {
@@ -144,6 +159,10 @@ source_set("libwebp_dsp_sse2") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
all_dependent_configs = [ ":libwebp_config" ]
if (!is_msan) {
@@ -167,6 +186,11 @@ if (use_dsp_neon) {
include_dirs = [ "." ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
+
if (current_cpu == "arm") {
# behavior similar to *.c.neon in an Android.mk
configs -= [ "//build/config/compiler:compiler_arm_fpu" ]
@@ -210,6 +234,10 @@ source_set("libwebp_enc") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
all_dependent_configs = [ ":libwebp_config" ]
@@ -242,6 +270,10 @@ source_set("libwebp_utils") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (set_opt_level) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
all_dependent_configs = [ ":libwebp_config" ]
« no previous file with comments | « no previous file | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698