Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1657113002:
libwebp: use -O2 on arm targets (Closed)
Descriptionlibwebp: use -O2 on arm targets
improves performance ~11-22% depending on the device and whether the
image was lossless or lossily compressed.
BUG=416951
Committed: https://crrev.com/e4e09c84ed53ac96c5cb86c3d5cdf806406a2c04
Cr-Commit-Position: refs/heads/master@{#374769}
Patch Set 1 #Patch Set 2 : relocate gn config manipulation #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 ========== to ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 ==========
jzern@chromium.org changed reviewers: + urvang@chromium.org
On 2016/02/02 00:10:45, jzern wrote: > mailto:jzern@chromium.org changed reviewers: > + mailto:urvang@chromium.org Urvang, if you're OK with this it may be worth holding off on submitting for a few days to allow any responses on the bug thread.
On 2016/02/02 00:13:38, jzern wrote: > On 2016/02/02 00:10:45, jzern wrote: > > mailto:jzern@chromium.org changed reviewers: > > + mailto:urvang@chromium.org > > Urvang, if you're OK with this it may be worth holding off on submitting for a > few days to allow any responses on the bug thread. Yup, looks OK. Will just LGTM without CQ.
The CQ bit was checked by jzern@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657113002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The config changes in gn need to be associated with the target. I considered storing the values in a list, but thought the variable was clearer especially since I elected to leave the demuxer at the default; it shouldn't have much speed impact. I verified the flags were being set in a local gn build using 'gn args': target_os = "android" target_cpu = "arm" is_debug = false
The CQ bit was checked by jzern@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from urvang@chromium.org Link to the patchset: https://codereview.chromium.org/1657113002/#ps20001 (title: "relocate gn config manipulation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657113002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/02/10 21:38:25, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Looks like a timeout.
The CQ bit was checked by jzern@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1657113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1657113002/20001
Message was sent while issue was closed.
Description was changed from ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 ========== to ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 ========== to ========== libwebp: use -O2 on arm targets improves performance ~11-22% depending on the device and whether the image was lossless or lossily compressed. BUG=416951 Committed: https://crrev.com/e4e09c84ed53ac96c5cb86c3d5cdf806406a2c04 Cr-Commit-Position: refs/heads/master@{#374769} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e4e09c84ed53ac96c5cb86c3d5cdf806406a2c04 Cr-Commit-Position: refs/heads/master@{#374769} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
