Remove unnecessary loop and quit in CronetChunkedOutputStream

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
 import org.chromium.net.UploadDataProvider;
 import org.chromium.net.UploadDataSink;
 
 import java.io.IOException;
@@ skipping 64 matching lines @@
             }
             int sent = Math.min(toSend, mBuffer.limit() - mBuffer.position());
             mBuffer.put(buffer, offset + count - toSend, sent);
             toSend -= sent;
         }
         mBytesWritten += count;
     }
 
     @Override
     public void close() throws IOException {
         if (!mLastChunk) {

[pauljensen, 2016/02/04 15:27:26]

I think we can get rid of this if-statement now.

[xunjieli, 2016/07/08 14:02:14]

Done.

             // Write last chunk.
             mLastChunk = true;
-            mMessageLoop.loop();
         }
         mClosed = true;
     }
 
     private void checkNotClosed() throws IOException {
         if (mClosed) {
             throw new IOException("Stream has been closed.");
         }
     }
 
@@ skipping 31 matching lines @@
                 // Move remaining buffer to the head of the buffer for use in the
                 // next read call.
                 mBuffer.compact();
                 uploadDataSink.onReadSucceeded(false);
             } else {
                 // byteBuffer has enough capacity to hold the content of mBuffer.
                 mBuffer.flip();
                 byteBuffer.put(mBuffer);
                 // Reuse this buffer.
                 mBuffer.clear();
-                // Quit message loop so embedder can write more data.
-                mMessageLoop.quit();
                 uploadDataSink.onReadSucceeded(mLastChunk);
+                if (!mLastChunk) {
+                    // Quit message loop so embedder can write more data.
+                    mMessageLoop.quit();
+                }
             }
         }
 
         @Override
         public void rewind(UploadDataSink uploadDataSink) {
             uploadDataSink.onRewindError(
                     new HttpRetryException("Cannot retry streamed Http body", -1));
         }
     }
 }