Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16571008: Get rid of pixelSnapped* from IntRect. These are unused. (Closed)

Created:
7 years, 6 months ago by jbroman
Modified:
7 years, 6 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, Rik, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Get rid of pixelSnapped* from IntRect. These are unused. BUG=247644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152039

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M Source/core/platform/graphics/IntRect.h View 4 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
Just listening to a FIXME. :)
7 years, 6 months ago (2013-06-07 14:26:51 UTC) #1
pdr.
LGTM with nits https://codereview.chromium.org/16571008/diff/1/Source/core/platform/graphics/IntRect.cpp File Source/core/platform/graphics/IntRect.cpp (right): https://codereview.chromium.org/16571008/diff/1/Source/core/platform/graphics/IntRect.cpp#newcode32 Source/core/platform/graphics/IntRect.cpp:32: #include "wtf/Vector.h" Is this needed?
7 years, 6 months ago (2013-06-07 17:17:14 UTC) #2
jbroman
https://codereview.chromium.org/16571008/diff/1/Source/core/platform/graphics/IntRect.cpp File Source/core/platform/graphics/IntRect.cpp (right): https://codereview.chromium.org/16571008/diff/1/Source/core/platform/graphics/IntRect.cpp#newcode32 Source/core/platform/graphics/IntRect.cpp:32: #include "wtf/Vector.h" On 2013/06/07 17:17:14, pdr wrote: > Is ...
7 years, 6 months ago (2013-06-07 17:22:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/16571008/7001
7 years, 6 months ago (2013-06-07 17:22:47 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 18:54:58 UTC) #5
Message was sent while issue was closed. 
Change committed as 152039

Powered by Google App Engine
This is Rietveld 408576698