chrome/browser/gtk/repost_form_warning_gtk.cc - Issue 1657005: Merge 44481 - Ensure proper teardown of repost form warning objects....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/repost_form_warning_gtk.cc

Issue 1657005: Merge 44481 - Ensure proper teardown of repost form warning objects.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/375/src/

Patch Set: Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/gtk/repost_form_warning_gtk.cc

===================================================================

--- chrome/browser/gtk/repost_form_warning_gtk.cc (revision 44638)

+++ chrome/browser/gtk/repost_form_warning_gtk.cc (working copy)

@@ -65,20 +65,13 @@

}

void RepostFormWarningGtk::DeleteDelegate() {

- Dismiss();

delete this;

}

RepostFormWarningGtk::~RepostFormWarningGtk() {

+ gtk_widget_destroy(dialog_);

}

-void RepostFormWarningGtk::Dismiss() {

- if (dialog_) {

- gtk_widget_destroy(dialog_);

- dialog_ = NULL;

- }

void RepostFormWarningGtk::OnRefresh(GtkWidget* widget) {

controller_->Continue();

}

« no previous file with comments | « chrome/browser/gtk/repost_form_warning_gtk.h ('k') | chrome/browser/repost_form_warning_controller.h » ('j') | no next file with comments »