Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/browser/cocoa/repost_form_warning_mac.mm

Issue 1657005: Merge 44481 - Ensure proper teardown of repost form warning objects.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/375/src/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/repost_form_warning_mac.h ('k') | chrome/browser/gtk/repost_form_warning_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/repost_form_warning_mac.mm
===================================================================
--- chrome/browser/cocoa/repost_form_warning_mac.mm (revision 44638)
+++ chrome/browser/cocoa/repost_form_warning_mac.mm (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/cocoa/repost_form_warning_mac.h"
#include "app/l10n_util_mac.h"
+#include "base/scoped_nsobject.h"
#include "chrome/browser/repost_form_warning_controller.h"
#include "grit/generated_resources.h"
@@ -51,7 +52,8 @@
: ConstrainedWindowMacDelegateSystemSheet(
[[[RepostDelegate alloc] initWithWarning:controller]
autorelease],
- @selector(alertDidEnd:returnCode:contextInfo:)) {
+ @selector(alertDidEnd:returnCode:contextInfo:)),
+ controller_(controller) {
scoped_nsobject<NSAlert> alert([[NSAlert alloc] init]);
[alert setMessageText:
l10n_util::GetNSStringWithFixup(IDS_HTTP_POST_WARNING_TITLE)];
@@ -68,17 +70,13 @@
}
RepostFormWarningMac::~RepostFormWarningMac() {
-}
-
-void RepostFormWarningMac::DeleteDelegate() {
- Dismiss();
- delete this;
-}
-
-void RepostFormWarningMac::Dismiss() {
NSWindow* window = [(NSAlert*)sheet() window];
if (window && is_sheet_open()) {
[NSApp endSheet:window
returnCode:NSAlertSecondButtonReturn];
}
}
+
+void RepostFormWarningMac::DeleteDelegate() {
+ delete this;
+}
« no previous file with comments | « chrome/browser/cocoa/repost_form_warning_mac.h ('k') | chrome/browser/gtk/repost_form_warning_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698