[parser] report invalid rest parameter errors in Arrow functions

[parser] report invalid rest parameter errors in Arrow functions

Based on vogelheim's CL at https://codereview.chromium.org/1657783002/

BUG=chromium:582626, v8:2700
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, vogelheim@chromium.org

Committed: https://crrev.com/15da984326b184a3d60b4f437c081c4a25789822
Cr-Commit-Position: refs/heads/master@{#33651}

[caitp (gmail), 2016-02-01 22:08:11]

PTAL, I think this is a more targeted fix for this crash

[caitp (gmail), 2016-02-01 22:14:33]

Patchset #1 (id:1) has been deleted

[caitp (gmail), 2016-02-01 22:19:23]

Patchset #1 (id:20001) has been deleted

[caitp (gmail), 2016-02-01 22:22:10]

Patchset #1 (id:40001) has been deleted

[caitp (gmail), 2016-02-01 23:10:22]

Patchset #1 (id:60001) has been deleted

[adamk, 2016-02-01 23:15:59]

https://codereview.chromium.org/1656993002/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1656993002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:1455: int ellipsis_pos;
I think this is a dup of "pos", below.

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:7978: TEST(MiscSyntaxErrors) {
Not sure this test makes any sense, some grouping seems like a good idea. I
liked before when these were up with similar bits (also, much easier to review
if you don't delete patch sets).

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:7993: "(...rest - a) => b",
Please add a test for the multi-arg version too (to make sure the preparser also
throws the error in that case).

[caitp (gmail), 2016-02-01 23:19:38]

will fix up in a sec

https://codereview.chromium.org/1656993002/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1656993002/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:1455: int ellipsis_pos;
On 2016/02/01 23:15:59, adamk wrote:
> I think this is a dup of "pos", below.

Acknowledged.

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:7978: TEST(MiscSyntaxErrors) {
On 2016/02/01 23:15:59, adamk wrote:
> Not sure this test makes any sense, some grouping seems like a good idea. I
> liked before when these were up with similar bits (also, much easier to review
> if you don't delete patch sets).

I was just getting rid of ones that weren't quite doing what they were supposed
to be doing yet, sorry.

I'll put them back with the Arrow function syntax tests

https://codereview.chromium.org/1656993002/diff/80001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:7993: "(...rest - a) => b",
On 2016/02/01 23:15:59, adamk wrote:
> Please add a test for the multi-arg version too (to make sure the preparser
also
> throws the error in that case).

Acknowledged.

[adamk, 2016-02-01 23:55:11]

lgtm

[caitp (gmail), 2016-02-01 23:55:54]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-02-01 23:56:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656993002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656993002/90001

[commit-bot: I haz the power, 2016-02-02 00:30:54]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2016-02-02 00:33:20]

Description was changed from

==========
[parser] report invalid rest parameter errors in Arrow functions

Based on vogelheim's CL at https://codereview.chromium.org/1657783002/

BUG=chromium:582626, v8:2700
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, vogelheim@chromium.org
==========

to

==========
[parser] report invalid rest parameter errors in Arrow functions

Based on vogelheim's CL at https://codereview.chromium.org/1657783002/

BUG=chromium:582626, v8:2700
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, vogelheim@chromium.org

Committed: https://crrev.com/15da984326b184a3d60b4f437c081c4a25789822
Cr-Commit-Position: refs/heads/master@{#33651}
==========

[commit-bot: I haz the power, 2016-02-02 00:33:21]

Patchset 2 (id:??) landed as
https://crrev.com/15da984326b184a3d60b4f437c081c4a25789822
Cr-Commit-Position: refs/heads/master@{#33651}