Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1656983002: Remove dependency from content_renderer on startup_metric_utils_common. (Closed)

Created:
4 years, 10 months ago by fdoray
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency from content_renderer on startup_metric_utils_common. This dependency was used to send an IPC from a renderer process to the browser process when the RendererMain function was entered. With this CL, the IPC is sent from ChromeContentRendererClient to avoid the content_renderer -> startup_metric_utils_common dependency. BUG= Committed: https://crrev.com/e162f1dd724962d0d77c723c926b40a4e7ca3f0e Cr-Commit-Position: refs/heads/master@{#373169}

Patch Set 1 #

Total comments: 2

Patch Set 2 : record time in constructor #

Patch Set 3 : format #

Total comments: 2

Patch Set 4 : renderer_main_entry_time_ > main_entry_time_ #

Patch Set 5 : don`t change line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 chunks +7 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 10 months ago (2016-02-01 21:53:06 UTC) #2
jam
https://codereview.chromium.org/1656983002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/1656983002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode328 chrome/renderer/chrome_content_renderer_client.cc:328: renderer_main_entry_time_ = base::TimeTicks::Now(); why not just do this in ...
4 years, 10 months ago (2016-02-01 23:28:02 UTC) #3
fdoray
jam@: ptal https://codereview.chromium.org/1656983002/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/1656983002/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode328 chrome/renderer/chrome_content_renderer_client.cc:328: renderer_main_entry_time_ = base::TimeTicks::Now(); On 2016/02/01 23:28:02, jam ...
4 years, 10 months ago (2016-02-02 01:32:49 UTC) #4
jam
lgtm https://codereview.chromium.org/1656983002/diff/40001/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/1656983002/diff/40001/chrome/renderer/chrome_content_renderer_client.cc#newcode303 chrome/renderer/chrome_content_renderer_client.cc:303: : renderer_main_entry_time_(base::TimeTicks::Now()) { nit: renderer_ is redundant
4 years, 10 months ago (2016-02-02 23:53:18 UTC) #5
fdoray
https://codereview.chromium.org/1656983002/diff/40001/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): https://codereview.chromium.org/1656983002/diff/40001/chrome/renderer/chrome_content_renderer_client.cc#newcode303 chrome/renderer/chrome_content_renderer_client.cc:303: : renderer_main_entry_time_(base::TimeTicks::Now()) { On 2016/02/02 23:53:18, jam wrote: > ...
4 years, 10 months ago (2016-02-03 02:56:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656983002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656983002/80001
4 years, 10 months ago (2016-02-03 02:57:15 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-03 04:27:09 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 04:28:02 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e162f1dd724962d0d77c723c926b40a4e7ca3f0e
Cr-Commit-Position: refs/heads/master@{#373169}

Powered by Google App Engine
This is Rietveld 408576698