Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1656933006: [interpreter] Make branch analysis result const again. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Make branch analysis result const again. Now that the branch analysis result is no longer mutated by the graph builder, it can be made const again to preserve immutability. R=bmeurer@chromium.org Committed: https://crrev.com/7feaf896bb5d64b27230070d0fe3b7b2027d579a Cr-Commit-Position: refs/heads/master@{#33669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-02 09:58:39 UTC) #1
rmcilroy
lgtm
4 years, 10 months ago (2016-02-02 10:12:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656933006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656933006/1
4 years, 10 months ago (2016-02-02 10:37:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 10:40:56 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 10:47:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7feaf896bb5d64b27230070d0fe3b7b2027d579a
Cr-Commit-Position: refs/heads/master@{#33669}

Powered by Google App Engine
This is Rietveld 408576698