Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1656933004: Printing: Remove backslashes from print job names. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: Remove backslashes from print job names. Backslashes can cause printers to barf up paper. BUG=581708 Committed: https://crrev.com/3ccfd1fef6b8cd897682e26cb07ea182349b3747 Cr-Commit-Position: refs/heads/master@{#373347}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M printing/printing_utils.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M printing/printing_utils_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Lei Zhang
4 years, 10 months ago (2016-02-01 23:27:38 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1656933004/diff/1/chrome/browser/printing/print_job_worker.cc File chrome/browser/printing/print_job_worker.cc (right): https://codereview.chromium.org/1656933004/diff/1/chrome/browser/printing/print_job_worker.cc#newcode262 chrome/browser/printing/print_job_worker.cc:262: printing::SimplifyDocumentTitle(document_->name()); Maybe in SimplifyDocumentTitle? That was added for similar ...
4 years, 10 months ago (2016-02-02 04:50:37 UTC) #3
Lei Zhang
On 2016/02/02 04:50:37, Vitaly Buka wrote: > https://codereview.chromium.org/1656933004/diff/1/chrome/browser/printing/print_job_worker.cc > File chrome/browser/printing/print_job_worker.cc (right): > > https://codereview.chromium.org/1656933004/diff/1/chrome/browser/printing/print_job_worker.cc#newcode262 ...
4 years, 10 months ago (2016-02-03 01:06:13 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 10 months ago (2016-02-03 19:10:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656933004/20001
4 years, 10 months ago (2016-02-03 20:23:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 21:46:41 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:48:16 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3ccfd1fef6b8cd897682e26cb07ea182349b3747
Cr-Commit-Position: refs/heads/master@{#373347}

Powered by Google App Engine
This is Rietveld 408576698