Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: content/browser/service_worker/service_worker_database_unittest.cc

Issue 1656933003: Add origins argument to registerForeignFetchScopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_database_unittest.cc
diff --git a/content/browser/service_worker/service_worker_database_unittest.cc b/content/browser/service_worker/service_worker_database_unittest.cc
index 2b99bb4206ffd14994ecc65674a02af62c146ebe..b74aec67767a77ede2ce117918c0060d5fce17ab 100644
--- a/content/browser/service_worker/service_worker_database_unittest.cc
+++ b/content/browser/service_worker/service_worker_database_unittest.cc
@@ -70,6 +70,7 @@ void VerifyRegistrationData(const RegistrationData& expected,
EXPECT_EQ(expected.resources_total_size_bytes,
actual.resources_total_size_bytes);
EXPECT_EQ(expected.foreign_fetch_scopes, actual.foreign_fetch_scopes);
+ EXPECT_EQ(expected.foreign_fetch_origins, actual.foreign_fetch_origins);
}
void VerifyResourceRecords(const std::vector<Resource>& expected,
@@ -758,6 +759,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Overwrite) {
data.version_id = 200;
data.resources_total_size_bytes = 10 + 11;
data.foreign_fetch_scopes.push_back(URL(origin, "/foo"));
+ data.foreign_fetch_origins.push_back(GURL("https://chromium.org"));
std::vector<Resource> resources1;
resources1.push_back(CreateResource(1, URL(origin, "/resource1"), 10));
@@ -787,6 +789,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Overwrite) {
updated_data.version_id = data.version_id + 1;
updated_data.resources_total_size_bytes = 12 + 13;
updated_data.foreign_fetch_scopes.clear();
+ updated_data.foreign_fetch_origins.push_back(GURL("https://example.com"));
std::vector<Resource> resources2;
resources2.push_back(CreateResource(3, URL(origin, "/resource3"), 12));
resources2.push_back(CreateResource(4, URL(origin, "/resource4"), 13));

Powered by Google App Engine
This is Rietveld 408576698