third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 1656933003: Add origins argument to registerForeignFetchScopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 1656933003: Add origins argument to registerForeignFetchScopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add url::Origin::operator== to make tests simpler Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 7f7cfeb15b84edee7abccd91d58b689fbfcb27b8..90f3d1a77af807c6b18d72b1e0b03eb4dbf17b85 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -147,9 +147,9 @@ void ServiceWorkerGlobalScopeClientImpl::navigate(const WebString& clientUUID, c

m_client.navigate(clientUUID, url, callback);

}

-void ServiceWorkerGlobalScopeClientImpl::registerForeignFetchScopes(const WebVector<WebURL>& subScopes)

+void ServiceWorkerGlobalScopeClientImpl::registerForeignFetchScopes(const WebVector<WebURL>& subScopes, const WebVector<WebSecurityOrigin>& origins)

{

- m_client.registerForeignFetchScopes(subScopes);

+ m_client.registerForeignFetchScopes(subScopes, origins);

}

ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(WebServiceWorkerContextClient& client)