content/renderer/service_worker/service_worker_context_client.cc - Issue 1656933003: Add origins argument to registerForeignFetchScopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1656933003: Add origins argument to registerForeignFetchScopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add url::Origin::operator== to make tests simpler Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.h ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index 7d5212f84030d87c33b2fa4e8da648eb96d89d11..b3f0bb5669042518832daa2e8ae0621847ef3ed3 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -48,6 +48,7 @@

#include "third_party/WebKit/public/platform/WebMessagePortChannel.h"

#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"

#include "third_party/WebKit/public/platform/WebReferrerPolicy.h"

+#include "third_party/WebKit/public/platform/WebSecurityOrigin.h"

#include "third_party/WebKit/public/platform/WebString.h"

#include "third_party/WebKit/public/platform/modules/background_sync/WebSyncRegistration.h"

#include "third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h"

@@ -673,9 +674,11 @@ void ServiceWorkerContextClient::claim(

}

void ServiceWorkerContextClient::registerForeignFetchScopes(

- const blink::WebVector<blink::WebURL>& sub_scopes) {

+ const blink::WebVector<blink::WebURL>& sub_scopes,

+ const blink::WebVector<blink::WebSecurityOrigin>& origins) {

Send(new ServiceWorkerHostMsg_RegisterForeignFetchScopes(

- GetRoutingID(), std::vector<GURL>(sub_scopes.begin(), sub_scopes.end())));

+ GetRoutingID(), std::vector<GURL>(sub_scopes.begin(), sub_scopes.end()),

+ std::vector<url::Origin>(origins.begin(), origins.end())));

}

void ServiceWorkerContextClient::DispatchSyncEvent(